Skip to content

fix: friendly error when registering a node with a duplicate name #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theFong wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: friendly error when registering a node with a duplicate name #413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96e8241
fix: friendly error when registering a node with a duplicate name
theFong Jun 24, 2026
eacfad0
fix: also match connect AlreadyExists code for duplicate node name
theFong Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/cmd/register/register.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,14 @@ func runRegisterSteps(ctx context.Context, t *terminal.Terminal, s RegisterStore
NodeSpec: toProtoNodeSpec(hwProfile),
}))
if err != nil {
// Newer dev-plane returns CodeAlreadyExists for a duplicate node name.
// Older dev-plane leaks the raw Postgres unique-constraint error, so we
// also match the constraint name for backwards compatibility until the
// server change is fully rolled out.
if connect.CodeOf(err) == connect.CodeAlreadyExists ||
strings.Contains(err.Error(), "externalnode_organization_id_name") {

@drewmalin drewmalin Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need to worry about backwards compatibility here as we can just ship the devplane side immediately, and this index name could be changed in the future.

return nil, fmt.Errorf("a node with this name already exists")

@drewmalin drewmalin Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably just use the inner error message here, as that will contain the true "node already exists" message

}
return nil, fmt.Errorf("failed to register node: %w", err)
}

Expand Down
Loading