Skip to content

fix: resolve timezone skew and Windows path URL formatting in unit tests #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tushar2682 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: resolve timezone skew and Windows path URL formatting in unit tests #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/java/com/braintreegateway/unittest/ThreeDSecureLookupRequestTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ public void serializesPriorAuthenticationDetails() {
" }\n" +
"}";

Calendar authTime = Calendar.getInstance();
Calendar authTime = Calendar.getInstance(java.util.TimeZone.getTimeZone("UTC"));
authTime.set(2024, Calendar.FEBRUARY, 10, 22, 45, 30);

ThreeDSecureLookupPriorAuthenticationDetails priorAuthenticationDetails = new ThreeDSecureLookupPriorAuthenticationDetails()
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/braintreegateway/unittest/TransactionIndustryRequestTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public void toXMLIncludesAllElements() throws IOException, SAXException {
TransactionRequest txnRequest = new TransactionRequest();
TransactionIndustryRequest request = new TransactionIndustryRequest(txnRequest);

Calendar arrivalDate = Calendar.getInstance();
Calendar arrivalDate = Calendar.getInstance(java.util.TimeZone.getTimeZone("UTC"));
arrivalDate.set(2023, Calendar.FEBRUARY, 10, 22, 45, 30);

request.industryType(Transaction.IndustryType.TRAVEL_FLIGHT)
Expand Down
6 changes: 2 additions & 4 deletions src/test/java/com/braintreegateway/unittest/TransactionLevelFeeReportTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
public class TransactionLevelFeeReportTest {
@Test
public void interchangeReportIsParsed() throws IOException, ParseException {
String url = "file://"
+ new File("src/test/resources/fixtures/transaction_level_interchange_fee_report.csv").getAbsolutePath();
String url = new File("src/test/resources/fixtures/transaction_level_interchange_fee_report.csv").toURI().toURL().toString();
TransactionLevelFeeReport report = new TransactionLevelFeeReport(url);
assertEquals(9, report.getCSVRecords().size());

Expand Down Expand Up @@ -55,8 +54,7 @@ public void interchangeReportIsParsed() throws IOException, ParseException {

@Test
public void flatFeeReportIsParsed() throws IOException, ParseException {
String url =
"file://" + new File("src/test/resources/fixtures/transaction_level_fee_report.csv").getAbsolutePath();
String url = new File("src/test/resources/fixtures/transaction_level_fee_report.csv").toURI().toURL().toString();
TransactionLevelFeeReport report = new TransactionLevelFeeReport(url);
assertEquals(9, report.getCSVRecords().size());

Expand Down