Make the factory macro accept constructor arguments - #371
Merged
gennaroprota merged 1 commit intoAug 7, 2026
Conversation
This removes a closing parenthesis which erroneously sat after the condition of `BOOST_PP_IF` instead of after its third argument, in the three places deciding whether a comma separates two constructor arguments. Contextually, it also adds the includes for `BOOST_PP_COMMA` and `BOOST_PP_EMPTY`, which were missing. Fixes #215.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes a closing parenthesis which erroneously sat after the condition of
BOOST_PP_IFinstead of after its third argument, in the three places deciding whether a comma separates two constructor arguments.Contextually, it also adds the includes for
BOOST_PP_COMMAandBOOST_PP_EMPTY, which were missing.Fixes #215.