Remove stale core workspace package#183
Merged
Merged
Conversation
nahiyankhan
added a commit
that referenced
this pull request
Jun 24, 2026
Remove stale core workspace package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: infrastructure
User Impact: Ghost contributors have one internal core source of truth while the public package exports stay unchanged.
Problem: The package flattening left a private
@ghost/coreworkspace package beside the foldedpackages/ghost/src/ghost-coreruntime. That duplicated source, kept stale workspace/build/test references alive, and made the repo shape harder to reason about.Solution: Remove the stale workspace package, move its remaining tests into the unified public package test tree, point internal test imports at
#ghost-core, and refresh package metadata/docs/lockfile to match. The flattening changeset now uses the repo's pre-1.0 minor-release convention.Validation:
pnpm typecheck: passedpnpm test: passed, 404 testspnpm --filter @anarchitecture/ghost build: passedpnpm check:packed-package: passedpnpm check:terminology: passedpnpm check: passedpnpm checkand format checkspnpm build,pnpm test, andpnpm checkChangeset: added;
.changeset/flat-ghost-package.mdnow marks the flattening package-shape change asminorfor@anarchitecture/ghost.Ghost Review:
node packages/ghost/dist/bin.js check --base origin/main: passed with 0 findingsnode packages/ghost/dist/bin.js review --base origin/main: generated advisory review packet; packet diff was truncated because this PR deletes the old package tree, but no active deterministic failures were reported byghost checkFile changes
.changeset/config.json
Removed
@ghost/corefrom ignored packages because the private package no longer exists..changeset/flat-ghost-package.md
Changed the release bump from
majortominor.README.md
Updated the repo layout table so
packages/ghostis the single public package carrying the folded core runtime.packages/ghost-core/package.json
Deleted the obsolete private workspace package manifest.
packages/ghost-core/src/
Deleted the duplicate private core source tree now folded under
packages/ghost/src/ghost-core.packages/ghost-core/tsconfig.json
Deleted the obsolete TypeScript project config.
packages/ghost-core/test/*.test.ts
Moved the remaining private core tests into
packages/ghost/test/ghost-core/.packages/ghost/test/gate.test.ts
Replaced the old
@ghost/coretest import with#ghost-core.packages/ghost/test/ghost-core/*.test.ts
Preserved the moved core coverage under the unified package and updated imports to folded core exports; adjusted legacy grounding assertions to match the current warning-level contract.
pnpm-lock.yaml
Removed the
packages/ghost-coreworkspace importer.scripts/check-terminology.mjs
Removed stale scan roots for the deleted private package.
tsconfig.json
Removed the project reference to
packages/ghost-core.vitest.config.ts
Removed the
@ghost/corealias that only existed for the stale private package tests.Screenshots/Demos: N/A