feat(desktop): polish agent-session transcript UI atop declared-ownership model#1273
Draft
tellaho wants to merge 1 commit into
Draft
feat(desktop): polish agent-session transcript UI atop declared-ownership model#1273tellaho wants to merge 1 commit into
tellaho wants to merge 1 commit into
Conversation
…ship model Replay of PR #1061 (tho/activity-ui-polish) onto fresh main: lands the 20 UI-polish commits as one net diff, reconciled with #1229's merged declared-ownership model (viewerIsOwner = isCurrentUserOwner || isOwner) and #1089's content-visibility-auto virtualization. Notable reconciles: - markdown.tsx: ported the compact/tight variant system into main's newer lightbox/spoiler markdown component (rather than overwriting it), layering variant density/leading overrides after the base owl-spacing so tailwind-merge wins. Dropped the branch's hardcoded text-[15px] in favor of main's rem-token text-sm base (post-#1052 zoom-safe scale). - agentSessionTranscript.ts: pass TranscriptItemContext (not channelId). - managed_agents: thread avatar_url through ManagedAgentSummary so the transcript renders the assistant-bubble avatar from the pinned record snapshot; bumped runtime.rs size override 2001 -> 2002 for the +1 line. Observer-seed screenshots intentionally excluded (separate follow-up). Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Category: improvement
User Impact: The agent-session transcript view gets a polish pass — cleaner grouping, tool-call summaries, assistant-bubble avatars, and density-aware markdown — now reconciled with the declared-ownership activity model.
Problem: PR #1061 (
tho/activity-ui-polish) drifted 164 commits behind main and was based on a now-closed branch (tho/activity-ingress-ownership, #1060). A straight rebase was gnarly — the branch's own later commits delete what its early commits add. Meanwhile #1229 reworked activity authorization from key-custody to declared ownership, superseding the old ingress foundation.Solution: Replayed the 20 UI-polish commits as a single net diff onto fresh
main, dropping the 3 superseded ingress commits and hand-reconciling against #1229's merged model. The polish layers cleanly atopviewerIsOwner = isCurrentUserOwner || isOwnerrather than reverting it.Reconcile notes
markdown.tsx — ported the compact/tight variant system into main's newer lightbox/spoiler markdown component (rather than overwriting it), layering variant density/leading overrides after the base owl-spacing so tailwind-merge wins. Dropped the branch's hardcoded
text-[15px]in favor of main's rem-tokentext-smbase (post-#1052 zoom-safe scale).AgentSessionTranscriptList.tsx — preserved #1089's
content-visibility-autoon the item wrapper (perf win for long transcripts).agentSessionTranscript.ts — pass
TranscriptItemContext(notchannelId).managed_agents / runtime.rs — threaded
avatar_urlthroughManagedAgentSummaryso the transcript renders the assistant-bubble avatar from the pinned record snapshot; bumped runtime.rs size override 2001 → 2002 for the +1 line.Reproduction Steps
Validation
pnpm check(biome + file-sizes + px-text) ✓pnpm typecheck✓pnpm test— 1183 pass / 0 fail ✓cargo check✓