refactor(desktop): drop dead goose-set avatar refs#1228
Merged
tellaho merged 1 commit intoJun 24, 2026
Conversation
The goose avatar sets (fuzzies/gloopies/pollies) were removed from the project, so the filename-fallback support for them in gooseAppAvatarRefs is dead intent. Remove GOOSE_COLLECTION_ID_PATTERN, the allowFilenameFallback option, and the now-orphaned avatarRefFileFallback in resolveImportedPersonaAvatarUrl. The app-avatar: prefix parsing and runtime-avatar whitelist are untouched. Trim the fallback-dependent test and swap goose-set sample ids for neutral ones in remaining fixtures. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the dead goose-set avatar references from
gooseAppAvatarRefs, stacked on top of #1202 (agent avatar plumbing).The goose avatar sets (fuzzies / gloopies / pollies) were already pulled from the project as a separate effort around #1132, so #1202's support for them is dead intent. This strips the goose-set vocabulary and the now-orphaned code that only existed to serve it.
What changed
desktop/src/shared/avatars/gooseAppAvatarRefs.ts— removedGOOSE_COLLECTION_ID_PATTERN, theallowFilenameFallbackoption/type, the filename-fallback branch inparseGooseAppAvatarId, and the now-orphanedavatarRefFileFallbackinresolveImportedPersonaAvatarUrl. Collapsing the pattern made the whole fallback path dead, so it's removed rather than left as a vestigial option.gooseAppAvatarRefs.test.mjs— trimmed the fallback-only test; swapped goose-set sample ids for neutralpersona-*ones.commands/personas.rs,managed_agents/persona_card_tests.rs) — swapped goose-set sample ids for neutralpersona-*ids (used only as opaque ref strings).Untouched / confirmed independent: the
app-avatar:prefix parsing,isGooseAppAvatarRef(used byprofile/hooks.ts), and the runtime-avatar whitelist.resolveImportedPersonaAvatarUrlstill servespersonaDialogState.ts.Net: 4 files, +19/−60.
Stacking
kennylopez-agent-avatar-plumbing(Add agent avatar plumbing #1202's branch) — notmain.67eb982b.Verification
gooseAppAvatarRefsJS tests 6/6,pnpm typecheck,pnpm lintall clean.desktop-test,rust-tests,desktop-tauri-testall passed (validates the Rust fixture edits).