Refactor ChainQuery to be more flexible #2139
Draft
evanlinjin wants to merge 1 commit into
Draft
Conversation
Merged
3 tasks
evanlinjin
force-pushed
the
refactor/sans-io-mtp-chain-query
branch
2 times, most recently
from
6faf825 to
c1ad161
Compare
evanlinjin
force-pushed
the
refactor/sans-io-mtp-chain-query
branch
2 times, most recently
from
bdd7608 to
45bf03a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2139 +/- ##
==========================================
- Coverage 78.65% 78.30% -0.36%
==========================================
Files 30 31 +1
Lines 5909 6042 +133
Branches 279 281 +2
==========================================
+ Hits 4648 4731 +83
- Misses 1185 1237 +52
+ Partials 76 74 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
@evanlinjin the PR dependency is solved, #2038 landed on master! 🚀 🚀 |
evanlinjin
force-pushed
the
refactor/sans-io-mtp-chain-query
branch
2 times, most recently
from
52f2e92 to
3d4f44e
Compare
Rename `ChainQuery` to `ChainTask`.
Replace `ChainRequest`/`ChainResponse` with a poll-based `ChainTask`
trait. The driver calls `poll()` in a loop, resolving block-height
queries as needed. A generic parameter `B` (default `BlockHash`) lets
tasks receive richer block data (e.g. `Header`) from the chain source.
Add per-transaction and tip MTP fields to `CanonicalView`, computed
optionally via `CanonicalViewTask::with_mtp()`.
Add `BlockQueries` helper for tracking request/resolve state, and
`LocalChain::canonicalize{,_with_mtp}()` convenience methods.
evanlinjin
force-pushed
the
refactor/sans-io-mtp-chain-query
branch
from
3d4f44e to
d5d2fae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This builds on top of #2038.
ChainQuerycan fetch any block-data type (BlockHash,Header).CanonicalViewTaskcan fetch headers to calculate MTP values.CanoncialTx,CanonicalTxOuthas new MTP fields.Notes to the reviewers
WIP
Changelog notice
WIP
Checklists
All Submissions:
New Features: