Fix binding_arrays_are_usable check - #25261
Open
beicause wants to merge 1 commit into
Open
Conversation
JMS55
approved these changes
Aug 2, 2026
JMS55
added
C-Bug
kfc35
reviewed
Aug 2, 2026
| /// unimplemented in the GLSL backend of Naga. Therefore, we disable binding | ||
| /// arrays if the `shader_format_glsl` feature is present. | ||
| /// | ||
| /// 2. If there aren't enough texture bindings available to accommodate all the |
Contributor
There was a problem hiding this comment.
Probably need to update this comment with your changes?
Member
Author
There was a problem hiding this comment.
Not sure what needs to be updated; the comment still seems applicable.
kfc35
approved these changes
Aug 2, 2026
kfc35
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
binding_arrays_are_usablechecks unrelatedmax_storage_textures_per_shader_stagelimit (#10268), possibly because wgpu did not have relevant limits two years ago.Solution
Check
max_binding_array_elements_per_shader_stageandmax_binding_array_sampler_elements_per_shader_stage.Testing
None.