fix: fall back when Clipboard API write fails - #196
Open
Hexagon0000 wants to merge 1 commit into
Open
Conversation
Clipboard copy swallowed writeText errors and still showed the success checkmark. Add an execCommand fallback and only mark copied on success.
|
@Hexagon0000 is attempting to deploy a commit to the Benji Taylor's Projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
navigator.clipboard.writeTextfailures and still shows the success checkmark, so users think feedback was copied when the clipboard is empty.NotAllowedError: Document is not focused) and other non-secure or permission-restricted contexts.copyTextToClipboardwith anexecCommand('copy')fallback, and only set the copied UI state when a write actually succeeds (while still always invokingonCopy).Test plan
onCopystill firesMade with Cursor