Support gungraun json format - #962
Open
gamma0987 wants to merge 6 commits into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
|
| Project | Bencher |
| Branch | support-gungraun-json-format |
| Testbed | intel-v1 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| Adapter::Json | 📈 view plot 🚷 view threshold | 4.68 µs(+0.06%)Baseline: 4.68 µs | 5.00 µs (93.72%) |
| Adapter::Magic (JSON) | 📈 view plot 🚷 view threshold | 4.61 µs(+1.55%)Baseline: 4.54 µs | 4.81 µs (95.94%) |
| Adapter::Magic (Rust) | 📈 view plot 🚷 view threshold | 25.70 µs(-0.15%)Baseline: 25.74 µs | 26.98 µs (95.24%) |
| Adapter::Rust | 📈 view plot 🚷 view threshold | 3.52 µs(-0.23%)Baseline: 3.53 µs | 3.93 µs (89.63%) |
| Adapter::RustBench | 📈 view plot 🚷 view threshold | 3.52 µs(-0.32%)Baseline: 3.53 µs | 3.93 µs (89.46%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a gungraun JSON v6 adapter to complement the existing text-based gungraun parser, enabling users to consume machine-readable output directly.
What changed:
rust/gungraun.rs.AdapterRustGungraunJsoninlib/bencher_adapter/src/adapters/rust/gungraun_json.rsgungraun_summary::util::parse_slice()for version-aware parsing (only v6 currently)rust_gungraun_jsonadapter in addition to the existingrust_gungraunadapterDocumentation updates are intentionally deferred to a follow-up PR.
Note on benchmark naming and ids:
Already discussed in #778. This parser implementation uses (
file::group::function+::id) and the optional id as benchmark name to identify gungraun benchmarks uniquely. In addition to #778, I want to add that the main problem is that text parsed benchmark names include the "most likely" truncatedBenchmarkSummary::details. Exactly replicating the text parsed benchmark name is impossible because the user can disable or change the truncation length with configuration values. The JSON summary doesn't reflect that decision and doesn't store the user provided truncation configuration value. Required follow-up PR: A database migration to convert the old benchmark names to the new ones. Changing the old names to the new names is straightforward but irreversible although I don't think there's any need to go back.Closes #638