Skip to content

Major overhaul bids importer - #901

Merged
4gwe merged 34 commits into
developfrom
876_bids_taskid
Aug 2, 2026
Merged

Major overhaul bids importer#901
4gwe merged 34 commits into
developfrom
876_bids_taskid

Conversation

@gjheij

@gjheij gjheij commented May 27, 2026

Copy link
Copy Markdown
Contributor

Fixes #876.

Changes proposed in this pull request:

  • Fully compliant with BEP045/BEP020
  • Agnostic to task/run/ses etc
  • More modularity/subfunctions
  • Clips time series of different lengths to the shortest one (assuming StartTime is appropriately set)

@gjheij
gjheij requested a review from 4gwe May 27, 2026 10:54
@4gwe 4gwe self-assigned this May 27, 2026
@4gwe
4gwe merged commit 8429fea into develop Aug 2, 2026
1 check passed
@4gwe
4gwe deleted the 876_bids_taskid branch August 2, 2026 21:24
% Remove header/config rows if present
idx_header = strcmp(event_type, 'n/a') & ...
~strcmp(string(marker_tsv_data_table.message), 'CS');
idx_header = strcmp(event_type, 'n/a') & ~strcmp(string(marker_tsv_data_table.message), 'CS');

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message does not necessarily contain CS. It is in our case, but this depends on the local setup between EyeLink and stimulus presentation software. Could you check what happens if this is not CS?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll take a look.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About idx_header = strcmp(event_type, 'n/a') & ~strcmp(string(marker_tsv_data_table.message), 'CS'); this is only used to distinguish header/configuration rows from physioevents that correspond to a CS event in the behavioral events file, since both have event_type = 'n/a'.

In any case, we only import blink, saccade, and fixation events from physioevents. Therefore, if the message is not CS, that row would simply not be imported and would not affect the imported events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consistence regarding task-ID with pspm_import_bids

3 participants