fix(ci): Use source-version-override so CI Health builds checkout the right branch#5950
Merged
Merged
Conversation
… right branch The CI Health jobs passed the branch via `source-version`, which is not a valid input for aws-actions/aws-codebuild-run-build. The action ignored it and fell back to its default behavior of forcing sourceVersion to the commit that triggered the workflow (master / V3). As a result the v2 jobs (unit-tests-v2, slow-tests-v2, localmode-tests-v2) ran V2's tox commands against the V3 monorepo layout, where the repo root has no tox.ini, and failed within a minute with "tox config file not found". Rename all six occurrences to the correct input name `source-version-override` so each job checks out its intended branch (master-v2 for the v2 jobs and canaries-v2, master for canaries-v3 and unit-test-v3). X-AI-Prompt: Fix the CI Health workflow source-version input so v2 jobs run against master-v2 instead of master X-AI-Tool: kiro-cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI Health jobs passed the branch via
source-version, which is not a valid input for aws-actions/aws-codebuild-run-build. The action ignored it and fell back to its default behavior of forcing sourceVersion to the commit that triggered the workflow (master / V3). As a result the v2 jobs (unit-tests-v2, slow-tests-v2, localmode-tests-v2) ran V2's tox commands against the V3 monorepo layout, where the repo root has no tox.ini, and failed within a minute with "tox config file not found".Rename all six occurrences to the correct input name
source-version-overrideso each job checks out its intended branch (master-v2 for the v2 jobs and canaries-v2, master for canaries-v3 and unit-test-v3).Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.