Test add regression tests for syncclientclass#7066
Open
amirdeljouyi wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: add regression tests for SyncClientClass
Motivation and Context
Hey 👋
I added two regression tests for
SyncClientClassaround sync client generation behavior.While looking through the generation logic, I noticed the endpoint-discovery override path and EC2 protocol selection were not directly covered by the existing test suite.
Modifications
syncClientEndpointDiscovery_whenRequiredEndpointDiscoveryAllowsEndpointOverride_generatesFallbackAndWarning.getProtocolSpecs_withEc2Protocol_returnsEc2ProtocolSpec.Testing
These tests check that endpoint overrides generate the expected fallback and warning behavior for required endpoint discovery, and that EC2 models use the EC2 protocol spec.
Impact on coverage:
SyncClientClass.Targeted tests pass locally.
Screenshots (if appropriate)
Not applicable.
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License
I hope you find these tests useful. Please let me know if you have any questions or concerns.
Thanks,