Skip to content

Test add regression tests for syncclientclass#7066

Open
amirdeljouyi wants to merge 2 commits into
aws:masterfrom
amirdeljouyi:test-add-regression-tests-for-syncclientclass
Open

Test add regression tests for syncclientclass#7066
amirdeljouyi wants to merge 2 commits into
aws:masterfrom
amirdeljouyi:test-add-regression-tests-for-syncclientclass

Conversation

@amirdeljouyi

Copy link
Copy Markdown

test: add regression tests for SyncClientClass

Motivation and Context

Hey 👋

I added two regression tests for SyncClientClass around sync client generation behavior.

While looking through the generation logic, I noticed the endpoint-discovery override path and EC2 protocol selection were not directly covered by the existing test suite.

Modifications

  • Added syncClientEndpointDiscovery_whenRequiredEndpointDiscoveryAllowsEndpointOverride_generatesFallbackAndWarning.
  • Added getProtocolSpecs_withEc2Protocol_returnsEc2ProtocolSpec.

Testing

These tests check that endpoint overrides generate the expected fallback and warning behavior for required endpoint discovery, and that EC2 models use the EC2 protocol spec.

Impact on coverage:

  • Covers endpoint-discovery override handling, including covered lines for endpoint override warnings and covered lines for required endpoint-discovery fallback generation.
  • Covers EC2 protocol selection, including covered lines.
  • This adds about 3% line coverage and 12% branch coverage for SyncClientClass.

Targeted tests pass locally.

Screenshots (if appropriate)

Not applicable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

I hope you find these tests useful. Please let me know if you have any questions or concerns.

Thanks,

@amirdeljouyi amirdeljouyi requested a review from a team as a code owner June 23, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant