[Validators] Fix error message returned by validator ExistingFsxNetworkingValidator when Fsx has no ENI - #7567
Open
gmarciani wants to merge 1 commit into
Conversation
so that, when a shared storage does not return network interfaces, the validator fails with a clear error message instead of a generic `NoneType` error.
hgreebe
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixed issue with validator
ExistingFsxNetworkingValidatorso that, when a shared storage does not return network interfaces, the validator fails with a clear error message instead of a genericNoneTypeerror.UX
To validate the scenario I am triggering the pcluster update-cluster to mount an external FSx that does not have the ENI attached yet (it is still creating).
Before the fix
After the fix
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.