Skip to content

[Validators] Fix error message returned by validator ExistingFsxNetworkingValidator when Fsx has no ENI - #7567

Open
gmarciani wants to merge 1 commit into
aws:developfrom
gmarciani:wip/mgiacomo/3170/fix-storage-validator-0818-1
Open

[Validators] Fix error message returned by validator ExistingFsxNetworkingValidator when Fsx has no ENI#7567
gmarciani wants to merge 1 commit into
aws:developfrom
gmarciani:wip/mgiacomo/3170/fix-storage-validator-0818-1

Conversation

@gmarciani

@gmarciani gmarciani commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Description of changes

Fixed issue with validator ExistingFsxNetworkingValidator so that, when a shared storage does not return network interfaces, the validator fails with a clear error message instead of a generic NoneType error.

UX

To validate the scenario I am triggering the pcluster update-cluster to mount an external FSx that does not have the ENI attached yet (it is still creating).

Before the fix

  "configurationValidationErrors": [
    {
      "level": "ERROR",
      "type": "ExistingFsxNetworkingValidator",
      "message": "'NoneType' object is not iterable"
    },

After the fix

  "configurationValidationErrors": [
    {
      "level": "ERROR",
      "type": "ExistingFsxNetworkingValidator",
      "message": "Unable to validate FSx security groups. The given FSx file storage 'fs-09ae44abbca688213' doesn't have Elastic Network Interfaces attached to it."
    }
  ],

Tests

  1. Manually tested (see UX above)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

so that, when a shared storage does not return network interfaces,
the validator fails with a clear error message instead of a generic
`NoneType` error.
@gmarciani
gmarciani marked this pull request as ready for review August 18, 2026 21:24
@gmarciani
gmarciani requested review from a team as code owners August 18, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants