Skip to content

Lazy load multi-concurrent utilities for cold start improvement #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darklight3it merged 4 commits into from
Jun 25, 2026
+8 −3
Merged

Lazy load multi-concurrent utilities for cold start improvement #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aac70b8
fix: lazy load multi_concurrent_utils
darklight3it Jun 25, 2026
2ff0d2f
test: fix test to patch the runner correctly
darklight3it Jun 25, 2026
d2b14c0
chore: removed comment
darklight3it Jun 25, 2026
cc8c4f8
chore: add test for run_concurrent not being called in the non mc path
darklight3it Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion awslambdaric/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

from .lambda_config import LambdaConfigProvider
from .lambda_runtime_client import LambdaRuntimeClient
from .lambda_multi_concurrent_utils import MultiConcurrentRunner
from . import bootstrap


Expand All @@ -20,6 +19,9 @@ def main(args):
# Multi-concurrent mode: redirect fork, stdout/stderr and run
max_conc = int(config.max_concurrency)
socket_path = config.lmi_socket_path

from .lambda_multi_concurrent_utils import MultiConcurrentRunner
Comment thread
darklight3it marked this conversation as resolved.

MultiConcurrentRunner.run_concurrent(
handler, api_addr, use_thread, socket_path, max_conc
)
Expand Down
7 changes: 5 additions & 2 deletions tests/test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,12 @@


class TestMain(unittest.TestCase):
@patch("awslambdaric.lambda_multi_concurrent_utils.MultiConcurrentRunner")
@patch("awslambdaric.__main__.bootstrap")
@patch("awslambdaric.__main__.LambdaRuntimeClient")
@patch("awslambdaric.__main__.LambdaConfigProvider")
def test_default_path_invokes_runtime_client_and_bootstrap(
self, mock_config_provider, mock_client_cls, mock_bootstrap
self, mock_config_provider, mock_client_cls, mock_bootstrap, mock_runner
):
# Non-multi-concurrent mode
cfg = MagicMock()
Expand All @@ -30,7 +31,9 @@ def test_default_path_invokes_runtime_client_and_bootstrap(
"my.handler", mock_client_cls.return_value
)

@patch("awslambdaric.__main__.MultiConcurrentRunner")
mock_runner.run_concurrent.assert_not_called()

@patch("awslambdaric.lambda_multi_concurrent_utils.MultiConcurrentRunner")
@patch("awslambdaric.__main__.LambdaConfigProvider")
def test_multi_concurrent_path_dispatches_to_multi_concurrent_runner(
self, mock_config_provider, mock_runner
Expand Down
Loading