Fix DynamoDBAttributeValue String type check#632
Open
kiwigitops wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
==========================================
+ Coverage 75.12% 75.21% +0.08%
==========================================
Files 36 36
Lines 1419 1420 +1
==========================================
+ Hits 1066 1068 +2
+ Misses 274 273 -1
Partials 79 79 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kiwigitops
force-pushed
the
fix/dynamodb-string-accessor
branch
from
5b0bfab to
2662384
Compare
Author
|
Quick follow-up: I pushed a small lint cleanup after opening this PR. The focused events tests and go vet pass locally, and Codecov reports the modified lines covered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DynamoDBAttributeValue.String()enforceDataTypeString, matching its documented accessor behavior%#vformatting safe by moving the struct-formatting behavior toGoString()String()access and safe debug formattingCloses #510.
Tests
go test ./events