Skip to content

feat(plugin): Add result accessor to OperationEndInfo #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayushiahjolia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(plugin): Add result accessor to OperationEndInfo #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
137 changes: 126 additions & 11 deletions otel-plugin/src/test/java/software/amazon/lambda/durable/otel/ExecutionOtelPluginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,18 @@ void defaultConstructor_usesGlobalSdkTracerProviderDirectly() {
defaultPlugin.onOperationStart(
new OperationInfo("op-1", "step", "STEP", "Step", null, Instant.now(), null, false));
defaultPlugin.onOperationEnd(new OperationEndInfo(
"op-1", "step", "STEP", "Step", null, Instant.now(), Instant.now(), "SUCCEEDED", null, false, null));
"op-1",
"step",
"STEP",
"Step",
null,
Instant.now(),
Instant.now(),
"SUCCEEDED",
null,
false,
null,
null));
defaultPlugin.onInvocationEnd(
new InvocationEndInfo("req-1", "arn:exec1", true, InvocationStatus.SUCCEEDED, null));

Expand Down Expand Up @@ -229,7 +240,18 @@ void operationSpan_carriesAttemptNumberAtEnd() {
plugin.onInvocationStart(new InvocationInfo("req-1", ARN, true, Instant.now()));
plugin.onOperationStart(new OperationInfo("op-1", "flaky", "STEP", "Step", null, Instant.now(), null, false));
plugin.onOperationEnd(new OperationEndInfo(
"op-1", "flaky", "STEP", "Step", null, Instant.now(), Instant.now(), "SUCCEEDED", 3, false, null));
"op-1",
"flaky",
"STEP",
"Step",
null,
Instant.now(),
Instant.now(),
"SUCCEEDED",
3,
false,
null,
null));
plugin.onInvocationEnd(new InvocationEndInfo("req-1", ARN, true, InvocationStatus.SUCCEEDED, null));

var operationSpan = spanByName(spanExporter.getFinishedSpanItems(), "flaky");
Expand All @@ -246,7 +268,18 @@ void continuationOperationSpan_carriesAttemptNumber() {
plugin.onInvocationStart(new InvocationInfo("req-2", ARN, false, Instant.now()));
// No matching onOperationStart in this invocation — continuation branch.
plugin.onOperationEnd(new OperationEndInfo(
"op-1", "flaky", "STEP", "Step", null, Instant.now(), Instant.now(), "SUCCEEDED", 2, false, null));
"op-1",
"flaky",
"STEP",
"Step",
null,
Instant.now(),
Instant.now(),
"SUCCEEDED",
2,
false,
null,
null));
plugin.onInvocationEnd(new InvocationEndInfo("req-2", ARN, false, InvocationStatus.SUCCEEDED, null));

var operationSpan = spanByName(spanExporter.getFinishedSpanItems(), "flaky");
Expand All @@ -265,7 +298,7 @@ void operationSpan_startsAtOperationStartTimestamp() {
plugin.onInvocationStart(new InvocationInfo("req-1", ARN, true, Instant.now()));
plugin.onOperationStart(new OperationInfo("op-1", "step-a", "STEP", "Step", null, opStart, null, false));
plugin.onOperationEnd(new OperationEndInfo(
"op-1", "step-a", "STEP", "Step", null, opStart, opEnd, "SUCCEEDED", null, false, null));
"op-1", "step-a", "STEP", "Step", null, opStart, opEnd, "SUCCEEDED", null, false, null, null));
plugin.onInvocationEnd(new InvocationEndInfo("req-1", ARN, true, InvocationStatus.SUCCEEDED, null));

var operationSpan = spanByName(spanExporter.getFinishedSpanItems(), "step-a");
Expand All @@ -280,7 +313,18 @@ void operationSpan_parentedToWorkflow_linkedToInvocation() {
plugin.onInvocationStart(new InvocationInfo("req-1", ARN, true, Instant.now()));
plugin.onOperationStart(new OperationInfo("op-1", "step-a", "STEP", "Step", null, Instant.now(), null, false));
plugin.onOperationEnd(new OperationEndInfo(
"op-1", "step-a", "STEP", "Step", null, Instant.now(), Instant.now(), "SUCCEEDED", null, false, null));
"op-1",
"step-a",
"STEP",
"Step",
null,
Instant.now(),
Instant.now(),
"SUCCEEDED",
null,
false,
null,
null));
plugin.onInvocationEnd(new InvocationEndInfo("req-1", ARN, true, InvocationStatus.SUCCEEDED, null));

var spans = spanExporter.getFinishedSpanItems();
Expand All @@ -307,7 +351,18 @@ void attemptSpan_childOfOperation_linkedToInvocation() {
plugin.onUserFunctionEnd(new UserFunctionEndInfo(
"op-1", "compute", "STEP", "Step", null, Instant.now(), Instant.now(), false, 1, true, null));
plugin.onOperationEnd(new OperationEndInfo(
"op-1", "compute", "STEP", "Step", null, Instant.now(), Instant.now(), "SUCCEEDED", null, false, null));
"op-1",
"compute",
"STEP",
"Step",
null,
Instant.now(),
Instant.now(),
"SUCCEEDED",
null,
false,
null,
null));
plugin.onInvocationEnd(new InvocationEndInfo("req-1", ARN, true, InvocationStatus.SUCCEEDED, null));

var spans = spanExporter.getFinishedSpanItems();
Expand Down Expand Up @@ -347,6 +402,7 @@ void childOperation_parentedToParentOperationSpan() {
"SUCCEEDED",
null,
false,
null,
null));
plugin.onOperationEnd(new OperationEndInfo(
"op-parent",
Expand All @@ -359,6 +415,7 @@ void childOperation_parentedToParentOperationSpan() {
"SUCCEEDED",
null,
false,
null,
null));
plugin.onInvocationEnd(new InvocationEndInfo("req-1", ARN, true, InvocationStatus.SUCCEEDED, null));

Expand Down Expand Up @@ -420,7 +477,18 @@ void operationSuccess_setsOkOnOperationSpan() {
plugin.onInvocationStart(new InvocationInfo("req-1", ARN, true, Instant.now()));
plugin.onOperationStart(new OperationInfo("op-1", "step-ok", "STEP", "Step", null, Instant.now(), null, false));
plugin.onOperationEnd(new OperationEndInfo(
"op-1", "step-ok", "STEP", "Step", null, Instant.now(), Instant.now(), "SUCCEEDED", null, false, null));
"op-1",
"step-ok",
"STEP",
"Step",
null,
Instant.now(),
Instant.now(),
"SUCCEEDED",
null,
false,
null,
null));
plugin.onInvocationEnd(new InvocationEndInfo("req-1", ARN, true, InvocationStatus.SUCCEEDED, null));

var operationSpan = spanByName(spanExporter.getFinishedSpanItems(), "step-ok");
Expand All @@ -446,6 +514,7 @@ void operationEnd_withNonSuccessStatusAndNoError_leavesOperationSpanUnset() {
"CANCELLED",
null,
false,
null,
null));
plugin.onInvocationEnd(new InvocationEndInfo("req-1", ARN, true, InvocationStatus.SUCCEEDED, null));

Expand All @@ -469,6 +538,7 @@ void operationEnd_withoutStart_nonSuccessStatusAndNoError_leavesContinuationSpan
"TIMED_OUT",
null,
false,
null,
null));
plugin.onInvocationEnd(new InvocationEndInfo("req-2", ARN, false, InvocationStatus.SUCCEEDED, null));

Expand All @@ -484,7 +554,18 @@ void operationEnd_withNullStatusAndNoError_setsOkOnOperationSpan() {
plugin.onOperationStart(
new OperationInfo("op-ctx", "my-ctx", "CONTEXT", null, null, Instant.now(), null, false));
plugin.onOperationEnd(new OperationEndInfo(
"op-ctx", "my-ctx", "CONTEXT", null, null, Instant.now(), Instant.now(), null, null, false, null));
"op-ctx",
"my-ctx",
"CONTEXT",
null,
null,
Instant.now(),
Instant.now(),
null,
null,
false,
null,
null));
plugin.onInvocationEnd(new InvocationEndInfo("req-1", ARN, true, InvocationStatus.SUCCEEDED, null));

var operationSpan = spanByName(spanExporter.getFinishedSpanItems(), "my-ctx");
Expand Down Expand Up @@ -522,7 +603,18 @@ void operationOpenedThenCompletedNextInvocation_exportedOnceOnOperationEnd() {
// Invocation 2: the operation completes → materialized once via onOperationEnd, linked to this invocation.
plugin.onInvocationStart(new InvocationInfo("req-2", ARN, false, Instant.now()));
plugin.onOperationEnd(new OperationEndInfo(
"op-1", "my-wait", "WAIT", "Wait", null, Instant.now(), Instant.now(), "SUCCEEDED", null, false, null));
"op-1",
"my-wait",
"WAIT",
"Wait",
null,
Instant.now(),
Instant.now(),
"SUCCEEDED",
null,
false,
null,
null));
plugin.onInvocationEnd(new InvocationEndInfo("req-2", ARN, false, InvocationStatus.SUCCEEDED, null));

var spans = spanExporter.getFinishedSpanItems();
Expand All @@ -543,7 +635,18 @@ void allSpansShareTraceId_acrossInvocations() {
plugin.onInvocationStart(new InvocationInfo("req-1", ARN, true, Instant.now()));
plugin.onOperationStart(new OperationInfo("op-1", "step-1", "STEP", "Step", null, Instant.now(), null, false));
plugin.onOperationEnd(new OperationEndInfo(
"op-1", "step-1", "STEP", "Step", null, Instant.now(), Instant.now(), "SUCCEEDED", null, false, null));
"op-1",
"step-1",
"STEP",
"Step",
null,
Instant.now(),
Instant.now(),
"SUCCEEDED",
null,
false,
null,
null));
plugin.onInvocationEnd(new InvocationEndInfo("req-1", ARN, true, InvocationStatus.PENDING, null));
var firstTraceId = spanExporter.getFinishedSpanItems().get(0).getTraceId();
spanExporter.reset();
Expand Down Expand Up @@ -572,6 +675,7 @@ void operationEnd_withoutStart_createsContinuationSpanWithLink() {
"SUCCEEDED",
null,
false,
null,
null));
plugin.onInvocationEnd(new InvocationEndInfo("req-2", ARN, false, InvocationStatus.SUCCEEDED, null));

Expand Down Expand Up @@ -643,7 +747,18 @@ void xrayExtraction_allSpansShareExtractedTraceId() {
xrayPlugin.onOperationStart(
new OperationInfo("op-1", "step-a", "STEP", "Step", null, Instant.now(), null, false));
xrayPlugin.onOperationEnd(new OperationEndInfo(
"op-1", "step-a", "STEP", "Step", null, Instant.now(), Instant.now(), "SUCCEEDED", null, false, null));
"op-1",
"step-a",
"STEP",
"Step",
null,
Instant.now(),
Instant.now(),
"SUCCEEDED",
null,
false,
null,
null));
xrayPlugin.onInvocationEnd(new InvocationEndInfo("req-1", ARN, true, InvocationStatus.SUCCEEDED, null));

var spans = exporter.getFinishedSpanItems();
Expand Down
Loading
Loading