Skip to content

fix(plugin): Fire onOperationStart for all non-terminal operations during replay - #595

Merged
ayushiahjolia merged 1 commit into
mainfrom
fix/plugin-replay-all-operation-types
Aug 5, 2026
Merged

fix(plugin): Fire onOperationStart for all non-terminal operations during replay#595
ayushiahjolia merged 1 commit into
mainfrom
fix/plugin-replay-all-operation-types

Conversation

@ayushiahjolia

Copy link
Copy Markdown
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Issue Link, if available

#580
#493

Description

BaseDurableOperation.execute() hard-coded a type check that only fired onOperationStart with isReplay=true for STEP and CONTEXT operations during replay. Non-terminal WAIT, INVOKE, and CALLBACK operations were silently skipped, meaning plugins could not observe in-progress operations of those types between invocations.

Removed the if (getType() == OperationType.STEP || getType() == OperationType.CONTEXT) gate so onOperationStart fires for all non-terminal operations during replay.

Demo/Screenshots

N/A

Checklist

  • I have filled out every section of the PR template
  • I have thoroughly tested this change

Testing

Unit Tests

Have unit tests been written for these changes? Yes

Integration Tests

Have integration tests been written for these changes? N/A

Examples

Has a new example been added for the change? (if applicable) N/A

@ayushiahjolia
ayushiahjolia requested a review from a team August 5, 2026 23:33
@ayushiahjolia
ayushiahjolia requested a deployment to ai-pr-review-runtime August 5, 2026 23:33 — with GitHub Actions Waiting
@ayushiahjolia
ayushiahjolia requested a deployment to ai-pr-review-runtime August 5, 2026 23:33 — with GitHub Actions Waiting
@ayushiahjolia
ayushiahjolia merged commit 2ff058a into main Aug 5, 2026
31 of 34 checks passed
@ayushiahjolia
ayushiahjolia deleted the fix/plugin-replay-all-operation-types branch August 5, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants