feat: add reusable-slack-pr-review-notification workflow - #1
Merged
Conversation
Posts GitHub PR review activity to a Slack Workflow Builder webhook with @-mentions resolved from the SLACK_PR_REVIEW_USER_MAP secret. Three behaviors, inherited from the caller's on: block: - review_requested -> ping the requested reviewer - review submitted -> ping the PR author (approved/changes_requested/commented) - synchronize -> ping everyone who already reviewed or commented Requires inherited secrets SLACK_PR_REVIEW_WEBHOOK_URL and SLACK_PR_REVIEW_USER_MAP, fetched via fetch-secrets. Mirrors the reusable-slack-issue-notification pattern.
…ired slots - mentions now emit raw Slack IDs for Person-type Slack vars (real pinging pills) - triggers 1-4 use main_mention; branch_updated uses mention_1..5 (cap 5, warn on overflow) - Slack Person vars are required + reject empty, so unused slots are padded with a filler ID that Slack dedupes into an invisible pill - add requested_reviewers to the branch_updated union; drop pr_author
This was referenced Aug 7, 2026
aidandaly24
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a reusable workflow that posts GitHub PR review activity to Slack with real @-mentions, mirroring the existing
reusable-slack-issue-notificationpattern (webhook -> Slack Workflow Builder, branch onevent_type).Behaviors (inherited from the caller
on:block)pull_request: review_requestedpull_request_review: submittedpull_request: synchronizeMentions
Resolved from a github-login -> Slack member ID JSON secret
SLACK_PR_REVIEW_USER_MAP; unmapped logins fall back to plain@login(visible, no ping). Verified live: a mention to a non-author renders blue and notifies.Secrets (fetched via
fetch-secrets, both in DevX Secrets Manager631957124172)shared/SLACK_PR_REVIEW_WEBHOOK_URL— the "PR Summary" Slack workflow webhookshared/SLACK_PR_REVIEW_USER_MAP— login -> Slack ID JSONInjection guard
pr_titlepassed viaenv:+toJSON, matchingreusable-slack-issue-notification.Rollout
Callers (one per repo,
slack-pr-review-notification.yml) pin this reusable@<merge-SHA>— added after this merges.