fix(tui): auto-scroll via onContentHeightChange callback#507
Closed
avoidwork wants to merge 1 commit into
Closed
Conversation
Replace the messages-state-dependent scroll effect with ScrollView's onContentHeightChange callback. The previous approach tracked message count and streaming content hash, but never fired during streaming because messagesRef.current mutations don't change the messages array reference. onContentHeightChange fires when ink-scroll-view's internal content height actually changes — driven by MeasurableItem useLayoutEffect measurements — so it catches both streaming text growth and new messages without any state churn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the messages-state-dependent scroll effect with ScrollView's onContentHeightChange callback. The previous approach tracked message count and streaming content hash, but never fired during streaming because messagesRef.current mutations don't change the messages array reference.
onContentHeightChange fires when ink-scroll-view's internal content height actually changes — driven by MeasurableItem useLayoutEffect measurements — so it catches both streaming text growth and new messages without any state churn.
Type of Change
Testing
Describe the tests you wrote/run and their coverage. Use "N/A" if not applicable.
Coverage
Checklist
npm run lintpasses