Log the actual deadline when scheduling a future task - #510
Open
samliok wants to merge 3 commits into
Open
Conversation
FutureTask logged the monitor's current time under the "deadline" field instead of time.Add(timeout).
yacovm
approved these changes
Aug 14, 2026
samliok
marked this pull request as ready for review
August 14, 2026 21:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Monitor.FutureTask (simplex/monitor.go:159) logged the field "deadline" with the monitor's current base time, while the scheduled task's deadline is time.Add(timeout).
Consequence
The "Scheduling task" log line reports a "deadline" that is earlier than the real one by the full timeout, and disagrees with the "deadline" logged by tick() for the same task. This misled triage of a CI hang, where the logged "deadline" was read as the actual deadline.
Fix
Compute the deadline once and log it, instead of the base time.
Found while triaging a CI hang, where the misleading log field derailed the investigation.