Find verified unfinalized blocks on seq-only cache lookups - #504
Closed
samliok wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Duplicate of #497, which carries the same fix plus a unit test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of the cleanup-instance branch.
CachedStorage.Retrieveonly looked the cache up by digest, so seq-only lookups (which pass a zero digest) missed blocks that were verified but not yet finalized. Scan the cache by seq for those lookups.Related to the upcoming auxiliary info dissemination work: the aux history traversal retrieves blocks by seq with a zero digest, so this should merge before or alongside that stack.