Admit a build manifest beside every allowed artifact - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cux_ship's schema-2 sidecar (
<artifact>.manifest.json) now travels beside each artifact — authpass PR #421 uploads it, and the deb repackaging downloads it next to the tarball to derive the deb's own provenance record.The companion match is derived from the artifact rules by re-checking the stem, rather than a second list that could drift, and folds the suffix into the extension — so the
latestsymlink aliases the sidecar exactly the way it aliases its artifact, which is what the workflow_run consumer relies on. One level only:x.manifest.json.manifest.jsonstays refused.Functionally tested against the current allow-list: every artifact pattern's companion admitted, bare
evil.manifest.jsonrefused.Note for deploy: the server checkout serves this via symlink — a pull on web.sphene.net is the deploy. If artifact-cleanup.sh prunes by pattern, it should learn the companions in the same breath, or pruned artifacts leave orphaned sidecars behind.