Implements RetryConnectionMiddleware for Oracle - #1303
Open
DarkSide666 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
RetryConnectionMiddlewareand improve action workflow script for Oracle.This fixes issue caused by Oracle listener which we also often see in Atk tests.
On heavier connection load Oracle randomly becomes inaccessible because Oracle listener have some delay before it actually drops connection out of its cache after you disconnect from db. As result listener kind of "overflows" and don't allow to make new connections to DB even if previous connections are all nicely closed and not hit DBs connection limit.
Implementation have no BC breaks as connection retries are done purely on background.