fix(pr-template): generalize org-wide PR template - #68
Conversation
There was a problem hiding this comment.
The template change itself is correct and well-scoped: the role-specific checklist is genuinely meaningless for the org-wide default, the removed comment block referenced the wrong repo, and both copies are byte-identical as verified.
One open item: this changes a template inherited by every org repository, but there's no matching CHANGELOG.md entry. AGENTS.md lists updating CHANGELOG.md under Do, and the rolling CHANGELOG already tracks template-level changes. Please add a dated entry describing the generalization.
The template was copied from ansible.agent verbatim, so every PR in the organization opened with a role checklist naming only that collection's roles and a footer thanking contributors for the wrong repository while carrying an attribution line the commit conventions forbid. Both copies are kept in sync: the root file is the org-wide default, the one under templates/ is the bootstrap source for new repositories. Signed-off-by: Simon Bärlocher <s.baerlocher@sbaerlocher.ch>
AGENTS.md requires template-level changes to appear in the rolling changelog so consumer repositories can see them. Signed-off-by: Simon Bärlocher <s.baerlocher@sbaerlocher.ch>
09279e8 to
8144ef6
Compare
There was a problem hiding this comment.
All raised issues have been addressed. The security fixes in security-code.yml (env-passthrough for inputs, package-manager allowlist, printf-based summary) are correct, the pre-build-commands removal is properly documented, and the CHANGELOG entry covers all changes.
Summary
## Affected Component(s)list — the checklist came fromansible.agentand is meaningless in every other repository the org-wide template applies to.templates/so the org-wide default and the bootstrap source for new repositories stay in sync.The duplication itself was checked for replacement by a symlink and deliberately kept:
templates/is copied out into new repositories, where a link pointing back into this repo would not resolve, and GitHub reads only the root file for the org-wide default.Test plan