refactor(renovate): require review for arillso/.github updates - #67
refactor(renovate): require review for arillso/.github updates#67sbaerlocher wants to merge 2 commits into
Conversation
Date tags cannot carry a digest, so updates to our own reusable workflows were merged unreviewed within a day; a moved tag would have propagated org-wide to jobs holding write permissions. Signed-off-by: Simon Bärlocher <s.baerlocher@sbaerlocher.ch>
There was a problem hiding this comment.
Thanks — the intent (require human review for our own CI-provider updates) is sound, the JSON is valid, and moving the rationale into the description matches the style of the two other pinDigests: false exceptions.
One substantive issue and one convention gap:
1. Grouping undercuts the automerge:false (inline). This rule doesn't override the groupName inherited from the earlier "Automerge all non-major updates" rule, so arillso date-tag patch/minor bumps land in the shared "all non-major dependencies" group. Because Renovate ANDs automerge across a group's members, an arillso bump will block automerge for that whole batch instead of surfacing as its own reviewable PR. Adding "groupName": "arillso/.github" isolates it and delivers the standalone review the new description promises.
2. No CHANGELOG entry. This is a consumer-affecting behavior change to a shared Renovate preset, and the repo consistently documents renovate-base.json changes in CHANGELOG.md (per AGENTS.md). Please add a dated entry.
Without an own group the dependency inherited the shared non-major group, where Renovate resolves automerge across all members and one date-tag bump would have held back the entire batch. Signed-off-by: Simon Bärlocher <s.baerlocher@sbaerlocher.ch>
|
Closing: arillso/.github should track sbaerlocher/.github, which keeps |
Summary
automerge: falsefor thearillso/.githubpackage rule inrenovate-base.json. Date tags cannot carry a digest, sopinDigestsstays off — without automerge, a moved or compromised tag no longer propagates org-wide unreviewed within a day.pinDigests: falseexceptions in the file that already carry an inline justification.Test plan
renovate-config-validator renovate-base.jsonpasses (verified locally)