Skip to content

refactor(renovate): require review for arillso/.github updates - #67

Closed
sbaerlocher wants to merge 2 commits into
mainfrom
refactor/renovate-no-automerge-ci-provider
Closed

refactor(renovate): require review for arillso/.github updates#67
sbaerlocher wants to merge 2 commits into
mainfrom
refactor/renovate-no-automerge-ci-provider

Conversation

@sbaerlocher

Copy link
Copy Markdown
Member

Summary

  • Set automerge: false for the arillso/.github package rule in renovate-base.json. Date tags cannot carry a digest, so pinDigests stays off — without automerge, a moved or compromised tag no longer propagates org-wide unreviewed within a day.
  • Replaced the rule description with the reasoning, matching the two other pinDigests: false exceptions in the file that already carry an inline justification.

Test plan

  • renovate-config-validator renovate-base.json passes (verified locally)
  • CI green

Date tags cannot carry a digest, so updates to our own reusable workflows
were merged unreviewed within a day; a moved tag would have propagated
org-wide to jobs holding write permissions.

Signed-off-by: Simon Bärlocher <s.baerlocher@sbaerlocher.ch>
Comment thread renovate-base.json

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — the intent (require human review for our own CI-provider updates) is sound, the JSON is valid, and moving the rationale into the description matches the style of the two other pinDigests: false exceptions.

One substantive issue and one convention gap:

1. Grouping undercuts the automerge:false (inline). This rule doesn't override the groupName inherited from the earlier "Automerge all non-major updates" rule, so arillso date-tag patch/minor bumps land in the shared "all non-major dependencies" group. Because Renovate ANDs automerge across a group's members, an arillso bump will block automerge for that whole batch instead of surfacing as its own reviewable PR. Adding "groupName": "arillso/.github" isolates it and delivers the standalone review the new description promises.

2. No CHANGELOG entry. This is a consumer-affecting behavior change to a shared Renovate preset, and the repo consistently documents renovate-base.json changes in CHANGELOG.md (per AGENTS.md). Please add a dated entry.

Without an own group the dependency inherited the shared non-major group,
where Renovate resolves automerge across all members and one date-tag bump
would have held back the entire batch.

Signed-off-by: Simon Bärlocher <s.baerlocher@sbaerlocher.ch>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All raised issues have been addressed. The isolation fields correctly prevent the arillso dependency from inheriting the shared non-major group.

@sbaerlocher

Copy link
Copy Markdown
Member Author

Closing: arillso/.github should track sbaerlocher/.github, which keeps automerge: true for its own date-tagged preset updates. Keeping main as-is aligns the two presets.

@sbaerlocher sbaerlocher closed this Aug 7, 2026
@sbaerlocher
sbaerlocher deleted the refactor/renovate-no-automerge-ci-provider branch August 7, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant