Add StaticInputHandler protocol for zero-allocation input filling - #188
Draft
stikves wants to merge 2 commits into
Draft
Add StaticInputHandler protocol for zero-allocation input filling#188stikves wants to merge 2 commits into
stikves wants to merge 2 commits into
Conversation
Introduces InputBuffers (pre-allocated, reused across steps) and the StaticInputHandler protocol (inout fill pattern). TokenStaticInputHandler fills input_ids and position_ids without per-step allocation. Matches the state handler's bind(into:) pattern. The _modify accessor on InputBuffers subscript avoids COW overhead (measured 26× improvement over get/set in benchmarks). Existing SyncInputHandler is unchanged — this is additive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
InputBuffersandStaticInputHandler, a protocol for filling pre-allocated input buffers in-place without per-step allocation.Design
InputBuffers, creates once at init, passesinouteach step_modifyaccessor onInputBufferssubscript avoids COW (26× vs get/set)fill— handler holds no per-step stateSyncInputHandlerunchangedPrimary benefit is architectural (no COW risk, compile-time ownership via inout) rather than raw throughput.