ADFA-4658: fix NPE crash and empty-dialog trap in Kiwix settings (Wip…#190
Merged
Merged
Conversation
…e Cache then Select) RadioGroup.removeAllViews() keeps the group's checked id, so after Wipe Cache pressing Select found a null RadioButton and crashed at getTag() (PlannerController.java:508). Reset the checked id before wiping, guard the Select handler against a null button / empty spinner selection, and close the dialog after a wipe so the user is not left on an empty box with no exit.
…ose X, fix landscape) Wipe Cache no longer closes the dialog — it wipes and reloads the catalog. The dialog shows a 'Loading catalog from the Internet…' state while fetching and a clear offline state (with Retry) on failure, instead of a blank box. Adds an explicit Material close (X). Landscape was broken (Wipe/Select were off-screen); both layouts restructured so the actions are always visible with a bounded, scrollable variant list. Keeps the crash fix (clearCheck + guarded Select). New strings translated into all 33 locales (machine translation, pending review).
ImageView inflates as AppCompatImageView, so tint must be app:tint, not android:tint. Added the app namespace to both dialog layouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e Cache then Select)
RadioGroup.removeAllViews() keeps the group's checked id, so after Wipe Cache pressing Select found a null RadioButton and crashed at getTag() (PlannerController.java:508). Reset the checked id before wiping, guard the Select handler against a null button / empty spinner selection, and close the dialog after a wipe so the user is not left on an empty box with no exit.