ADFA-4633: Strip BouncyCastle PQC classes from keystore-generator-plugin APK#1504
Closed
davidschachterADFA wants to merge 1 commit into
Closed
ADFA-4633: Strip BouncyCastle PQC classes from keystore-generator-plugin APK#1504davidschachterADFA wants to merge 1 commit into
davidschachterADFA wants to merge 1 commit into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
…gin APK Adds a stripBcprovPqc Gradle task that repacks bcprov-jdk18on excluding org/bouncycastle/pqc/**, reducing APK size. Also wires in the root version catalog so the standalone plugin build can resolve plugin-api's dependencies. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
davidschachterADFA
force-pushed
the
adfa-4633
branch
from
332dc06 to
4331fad
Compare
Collaborator
|
Confusion. This version of the keystore generator is obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stripBcprovPqcGradle task that repacksbcprov-jdk18onexcludingorg/bouncycastle/pqc/**, so PQC classes never land in the APKbcprov-jdk18onfrombcpkix-jdk18on's transitive deps to prevent the unstripped jar from sneaking back ingradle/libs.versions.tomlin the standalone plugin project's settings soplugin-apican resolve its version catalog during standalone buildsTest plan
keystore-generator-pluginbuilds successfully via./gradlew assembleReleaseorg/bouncycastle/pqc/is absent from the output APK:unzip -l build/outputs/apk/release/*.apk | grep pqc🤖 Generated with Claude Code