enable secure processing in XsltTransformer to block XXE#1499
Open
Usamak06 wants to merge 1 commit into
Open
Conversation
XsltTransformer builds a TransformerFactory with external entity resolution still enabled, so a DOCTYPE in the markup it transforms can declare a SYSTEM entity and read local files. Turn on FEATURE_SECURE_PROCESSING, matching what XSLTResourceStream already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XsltTransformer.transform creates its TransformerFactory with external entity resolution still enabled, so a DOCTYPE in the markup being transformed can declare a SYSTEM entity and read local files off the server. The sibling XSLTResourceStream already guards against this, so I set the same FEATURE_SECURE_PROCESSING flag here. Added a regression test that feeds an external-entity payload through the transformer and checks the file contents are not returned.