Add unit tests for Continuation logic#13283
Open
JosiahWI wants to merge 2 commits into
Open
Conversation
This change was generated by Claude Opus 4.7 from API contracts I have not yet opened PRs for. It does not touch existing files other than one CMakeLists.txt, so it is low-risk. I reviewed each test case and they are good. I have not reviewed code semantics carefully for correctness. The default delay for the `CountingContinuation` wait is five seconds; I think a wait with a timeout is an acceptable way to test this, and five seconds should be plenty. If an event scheduled to run immediately doesn't call back the associated continuation within five seconds, that's probably unacceptable performance and worth failing the test for. :D
JosiahWI
commented
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was generated by Claude Opus 4.7 from API contracts I have not yet opened PRs for. It does not touch existing files other than one CMakeLists.txt, so it is low-risk.
I reviewed each test case and they are good. I have not reviewed code semantics carefully for correctness. The default delay for the
CountingContinuationwait is five seconds; I think a wait with a timeout is an acceptable way to test this, and five seconds should be plenty. If an event scheduled to run immediately doesn't call back the associated continuation within five seconds, that's probably unacceptable performance and worth failing the test for. :D