Skip to content

[SYNCOPE-1982] Improve query perfomance on OraclePlainSchemaRepoExtImpl#1450

Merged
ilgrosso merged 4 commits into
apache:4_1_Xfrom
valerio-crescia:SYNCOPE-1982
Jul 11, 2026
Merged

[SYNCOPE-1982] Improve query perfomance on OraclePlainSchemaRepoExtImpl#1450
ilgrosso merged 4 commits into
apache:4_1_Xfrom
valerio-crescia:SYNCOPE-1982

Conversation

@valerio-crescia

Copy link
Copy Markdown
Contributor

No description provided.

@ilgrosso

Copy link
Copy Markdown
Member

@valerio-crescia thanks for this PR

Please have a look at https://github.com/apache/syncope/actions/runs/29098192671/job/86380047982?pr=1450#step:8:202 since there are some integration test failures.

Also, since I've made a few adjustments in the code, please pull before making any further change.

@ilgrosso

Copy link
Copy Markdown
Member

@valerio-crescia the last change is too much superficial: it might let the tests succeed, but is just wrong as it barely flatten typed values to their default string representation. What could be happening with dates, for example?
Just look at other Oracle classes that are doing typesafe value comparison on queries and change the SQL query accordingly

@ilgrosso ilgrosso merged commit f787db8 into apache:4_1_X Jul 11, 2026
22 of 26 checks passed
@ilgrosso ilgrosso deleted the SYNCOPE-1982 branch July 11, 2026 06:44
@ilgrosso

Copy link
Copy Markdown
Member

With some minor adjustment, the code seems to be more robust.
Thank you @valerio-crescia : FYI I've cherry-picked this change to 4_0_X and master branches.

@valerio-crescia

Copy link
Copy Markdown
Contributor Author

You are welcome, and thanks for improving my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants