Skip to content

PHOENIX-7928 Re-baseline some missed tests#2533

Merged
apurtell merged 1 commit into
apache:PHOENIX-7876-featurefrom
apurtell:PHOENIX-7928
Jun 15, 2026
Merged

PHOENIX-7928 Re-baseline some missed tests#2533
apurtell merged 1 commit into
apache:PHOENIX-7876-featurefrom
apurtell:PHOENIX-7928

Conversation

@apurtell

Copy link
Copy Markdown
Contributor

Some tests that should have been updated during development were not updated. Re-baseline them.

IndexUsageIT (30), JsonFunctionsIT (1), SchemaToolExtractionIT (2), and CDCDefinitionIT (2)

Co-authored-by: Claude Opus 4.8[1m] <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates several integration tests’ expected outputs (“re-baselines”) to match current Phoenix behavior, particularly around DDL rendering and optimizer explain-plan rule labels.

Changes:

  • Update SchemaTool extraction test expectations to match current whitespace formatting in generated DDL.
  • Update explain-plan assertions to account for functional-index rule labels now emitted as matches <expr> (using prefix assertions).
  • Update CDC index PK column name expectations to match current formatting (no space after :).

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
phoenix-core/src/it/java/org/apache/phoenix/schema/tool/SchemaToolExtractionIT.java Align expected extracted index DDL formatting (LPAD expression spacing).
phoenix-core/src/it/java/org/apache/phoenix/end2end/json/JsonFunctionsIT.java Adjust explain-plan rule assertion for JSON expression index selection.
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexUsageIT.java Re-baseline multiple explain-plan rule assertions for expression/functional index usage.
phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCDefinitionIT.java Update expected CDC index PK column names to match current output formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@apurtell apurtell merged commit 771d379 into apache:PHOENIX-7876-feature Jun 15, 2026
@apurtell apurtell deleted the PHOENIX-7928 branch June 15, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants