[core][flink] Support external sort for manifest sort#8357
Open
discivigour wants to merge 12 commits into
Open
[core][flink] Support external sort for manifest sort#8357discivigour wants to merge 12 commits into
discivigour wants to merge 12 commits into
Conversation
discivigour
changed the title
JingsongLi
reviewed
Jun 25, 2026
| meta -> manifestFile.read(meta.fileName(), meta.fileSize()); | ||
| for (ManifestEntry entry : | ||
| sequentialBatchedExecute(reader, section, manifestReadParallelism)) { | ||
| sorter.write(entry); |
Contributor
There was a problem hiding this comment.
In the minor-compaction path, DELETE entries are also inserted into the external sorter, but writeSurvivingAddsToManifest later skips every DELETE row and the remaining deletes are sorted/written from deleteEntries. For delete-heavy manifests this duplicates serialization and spill IO. Could we feed only ADD entries into the external sorter and keep DELETE entries only in the map?
Contributor
Author
There was a problem hiding this comment.
ok, I will change it.
added 2 commits
June 25, 2026 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve manifest file sort compaction to avoid heap-heavy in-memory sorting for large manifest entries by introducing spillable external sorting. The change also propagates a Paimon IOManager through commit paths so manifest sort can use configured spill directories in Flink, while non-Flink/default contexts can keep IOManager creation local to the sorter.
Tests