NIFI-16078 - Fix StandardHashiCorpVaultClientService for non-token authentication#11396
Open
pvillard31 wants to merge 1 commit into
Open
NIFI-16078 - Fix StandardHashiCorpVaultClientService for non-token authentication#11396pvillard31 wants to merge 1 commit into
pvillard31 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-16078 - Fix StandardHashiCorpVaultClientService for non-token authentication
In NiFi 2.10.0,
spring-vault-corewas upgraded 4.0.1 → 4.1.0. Non-token auth methods now build their client viaAbstractVaultConfiguration.vaultClient(), which looks up aclientHttpRequestFactoryWrapperbean; AWS EC2 / Azure MSI also go throughrestClient()→getRestTemplateFactory(). Alsok, NiFi'sgetRestTemplateFactory()override was removed.NiFi configures
HashiCorpVaultConfigurationprogrammatically with an emptyStaticApplicationContext, so these bean lookups fail. Token authentication is unaffected (it needs no Vault client).With this change,
HashiCorpVaultConfiguration.setClientHttpRequestFactory(...)registers the request factory as theclientHttpRequestFactoryWrapperbean. We also restore thegetRestTemplateFactory()override built from that same factory. AndStandardHashiCorpVaultCommunicationServicepasses its configured (SSL Context Service–aware) factory beforeclientAuthentication(), so the auth client uses the same TLS material.Added new unit tests cover Kubernetes and AWS EC2 authentication; both reproduce the reported failure without the fix.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation