Skip to content

[INLONG-12149][Improve] [Manager] Add command whitelist validation in Manager#12155

Open
spiritxishi wants to merge 7 commits into
apache:masterfrom
spiritxishi:INLONG-12149
Open

[INLONG-12149][Improve] [Manager] Add command whitelist validation in Manager#12155
spiritxishi wants to merge 7 commits into
apache:masterfrom
spiritxishi:INLONG-12149

Conversation

@spiritxishi

@spiritxishi spiritxishi commented Jul 8, 2026 •
edited by dockerzhang
Loading

Copy link
Copy Markdown
Contributor

Fixes #12149

Motivation

Modifications

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@spiritxishi spiritxishi changed the title [INLONG-12149][Improve] [Agent] Add command whitelist validation in Manager [INLONG-12149][Improve] [Agent] Add command whitelist validation in Manager (#12149) Jul 8, 2026
@spiritxishi spiritxishi changed the title [INLONG-12149][Improve] [Agent] Add command whitelist validation in Manager (#12149) [INLONG-12149][Improve] [Agent] Add command whitelist validation in Manager Jul 8, 2026
@spiritxishi spiritxishi changed the title [INLONG-12149][Improve] [Agent] Add command whitelist validation in Manager [INLONG-12149][Improve] [Manager] Add command whitelist validation in Manager Jul 9, 2026
@dockerzhang dockerzhang requested a review from fuweng11 July 9, 2026 01:35
@dockerzhang dockerzhang changed the title [INLONG-12149][Improve] [Manager] Add command whitelist validation in Manager [INLONG-12149][Improve] [Manager] Add command whitelist validation in Manager (#12149) Jul 9, 2026
@dockerzhang dockerzhang changed the title [INLONG-12149][Improve] [Manager] Add command whitelist validation in Manager (#12149) [INLONG-12149][Improve] [Manager] Add command whitelist validation in Manager Jul 9, 2026
fuweng11
fuweng11 reviewed Jul 9, 2026
View reviewed changes
Comment thread ...anager-service/src/main/java/org/apache/inlong/manager/service/module/ModuleServiceImpl.java Outdated
Comment thread ...nager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/ErrorCodeEnum.java Outdated
Comment thread ...r-service/src/main/java/org/apache/inlong/manager/service/module/ModuleCommandValidator.java
Comment thread ...r-service/src/main/java/org/apache/inlong/manager/service/module/ModuleCommandValidator.java Outdated
Comment thread ...r-service/src/main/java/org/apache/inlong/manager/service/module/ModuleCommandValidator.java Outdated
Comment thread ...r-service/src/main/java/org/apache/inlong/manager/service/module/ModuleCommandValidator.java Outdated
Comment thread ...r-service/src/main/java/org/apache/inlong/manager/service/module/ModuleCommandValidator.java Outdated
Comment thread ...r-service/src/main/java/org/apache/inlong/manager/service/module/ModuleCommandValidator.java Outdated
Comment thread ...r-service/src/main/java/org/apache/inlong/manager/service/module/ModuleCommandValidator.java Outdated
Comment thread ...r-service/src/main/java/org/apache/inlong/manager/service/module/ModuleCommandValidator.java Outdated
fuweng11
fuweng11 reviewed Jul 9, 2026
View reviewed changes
Comment thread ...r-service/src/main/java/org/apache/inlong/manager/service/module/ModuleCommandValidator.java Outdated
Comment thread ...r-service/src/main/java/org/apache/inlong/manager/service/module/ModuleCommandValidator.java
Comment thread ...r-service/src/main/java/org/apache/inlong/manager/service/module/ModuleCommandValidator.java Outdated
Comment thread ...r-service/src/main/java/org/apache/inlong/manager/service/module/ModuleCommandValidator.java
fuweng11
fuweng11 previously approved these changes Jul 9, 2026
View reviewed changes
@spiritxishi spiritxishi requested a review from luchunliang July 9, 2026 11:52
luchunliang
luchunliang previously approved these changes Jul 9, 2026
View reviewed changes
Comment thread ...r-service/src/main/java/org/apache/inlong/manager/service/module/ModuleCommandValidator.java
@spiritxishi spiritxishi dismissed stale reviews from luchunliang and fuweng11 via 5bd0c8b July 10, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luchunliang luchunliang luchunliang approved these changes
@dockerzhang dockerzhang dockerzhang approved these changes
@fuweng11 fuweng11 fuweng11 approved these changes

Assignees

No one assigned

Labels

component/manager

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Improve][Manager] Add command whitelist validation in Manager

4 participants

@spiritxishi @luchunliang @dockerzhang @fuweng11