Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (35.52%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3527 +/- ##
============================================
- Coverage 74.44% 74.00% -0.45%
Complexity 937 937
============================================
Files 1243 1247 +4
Lines 125987 127567 +1580
Branches 101856 103480 +1624
============================================
+ Hits 93795 94402 +607
- Misses 29180 30077 +897
- Partials 3012 3088 +76
🚀 New features to boost your workflow:
|
hubcio
left a comment
There was a problem hiding this comment.
one finding lands on code outside this PR's diff so it can't be a line comment:
in core/binary_protocol/src/consensus/operation.rs, the command_code_roundtrip test's ops array skips from DeletePersonalAccessToken straight to SendMessages, omitting Operation::JoinConsumerGroup/LeaveConsumerGroup. this PR flips both from non-replicated to replicated-with-code, so their op<->code mapping in to_command_code/from_command_code is now live but unexercised by that test. add both variants (the lookup_by_operation_roundtrips_with_lookup_command array has the same omission).
|
/ready |
|
I cannot enable the hot/cold consumer group creation tests under |
|
/ready |
This PR ports the consumer group mechanism to server-ng, maintaining the cooperative rebalancing mechanism and extending it to accommodate for the fact that the server is distributed.