chore: remove once_cell in favor of the standard library#3524
Open
llogiq wants to merge 2 commits into
Open
Conversation
|
Thanks for the PR. It is labeled Slash commands (own line, regular comment) move it around the queue:
See CONTRIBUTING.md for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3524 +/- ##
============================================
+ Coverage 74.43% 74.96% +0.53%
Complexity 937 937
============================================
Files 1243 1240 -3
Lines 125698 123148 -2550
Branches 101618 99112 -2506
============================================
- Hits 93562 92317 -1245
+ Misses 29127 27812 -1315
- Partials 3009 3019 +10
🚀 New features to boost your workflow:
|
once_cell in favor of the standard libraryonce_cell in favor of the standard library
hubert-laserdata
approved these changes
Jun 22, 2026
hubcio
previously approved these changes
Jun 22, 2026
Contributor
|
Looks like conventional commits do not allow |
numinnex
previously approved these changes
Jun 22, 2026
Author
|
Thank you! |
Contributor
|
looks like CI is failing @llogiq |
Author
|
I had missed one place in the tests when adding files to the commit. Sorry. |
c15c7cc to
9d9e473
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
None, it's just one step to remove the
once_cellcrate from the build path.Rationale
Once the other dependencies using it have been updated to use the standard library types instead, the build will require one crate less.
What changed?
This just wholesale removes the
once_cellcrate from all iggy crate's dependencies, replacing all uses with the respective standard library types.Local Execution
AI Usage
None