Skip to content

chore: remove once_cell in favor of the standard library#3524

Open
llogiq wants to merge 2 commits into
apache:masterfrom
llogiq:not-even-once-cell
Open

chore: remove once_cell in favor of the standard library#3524
llogiq wants to merge 2 commits into
apache:masterfrom
llogiq:not-even-once-cell

Conversation

@llogiq

@llogiq llogiq commented Jun 21, 2026

Copy link
Copy Markdown

Which issue does this PR address?

None, it's just one step to remove the once_cell crate from the build path.

Rationale

Once the other dependencies using it have been updated to use the standard library types instead, the build will require one crate less.

What changed?

This just wholesale removes the once_cell crate from all iggy crate's dependencies, replacing all uses with the respective standard library types.

Local Execution

  • Passed
  • Pre-commit hooks ran

AI Usage

None

@github-actions

Copy link
Copy Markdown

Thanks for the PR. It is labeled S-waiting-on-review and queued for review.

Slash commands (own line, regular comment) move it around the queue:

  • /ready - back to S-waiting-on-review after addressing feedback
  • /author - flip to S-waiting-on-author while you finish changes
  • /request-review @user-or-team - request a reviewer

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Jun 21, 2026
@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.96%. Comparing base (f743591) to head (77b5bb0).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3524      +/-   ##
============================================
+ Coverage     74.43%   74.96%   +0.53%     
  Complexity      937      937              
============================================
  Files          1243     1240       -3     
  Lines        125698   123148    -2550     
  Branches     101618    99112    -2506     
============================================
- Hits          93562    92317    -1245     
+ Misses        29127    27812    -1315     
- Partials       3009     3019      +10     
Components Coverage Δ
Rust Core 75.89% <ø> (+0.74%) ⬆️
Java SDK 62.44% <ø> (ø)
C# SDK 71.40% <ø> (-0.71%) ⬇️
Python SDK 88.88% <ø> (ø)
PHP SDK 84.29% <ø> (ø)
Node SDK 91.22% <ø> (-0.13%) ⬇️
Go SDK 40.36% <ø> (ø)
Files with missing lines Coverage Δ
core/connectors/runtime/src/source.rs 80.11% <ø> (ø)
core/connectors/sdk/src/lib.rs 56.17% <ø> (ø)
core/connectors/sdk/src/sink.rs 75.59% <ø> (ø)
core/connectors/sdk/src/source.rs 82.99% <ø> (+2.72%) ⬆️
core/server_common/src/memory_pool.rs 67.56% <ø> (-2.44%) ⬇️

... and 75 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@numinnex numinnex changed the title chore(global): remove once_cell in favor of the standard library chore: remove once_cell in favor of the standard library Jun 22, 2026
hubcio
hubcio previously approved these changes Jun 22, 2026
@numinnex

Copy link
Copy Markdown
Contributor

Looks like conventional commits do not allow global as valid parameter. I've renamed the PR title and dropped it from the scope.

numinnex
numinnex previously approved these changes Jun 22, 2026
@llogiq

llogiq commented Jun 22, 2026

Copy link
Copy Markdown
Author

Thank you!

@hubcio

hubcio commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@llogiq llogiq dismissed stale reviews from numinnex and hubcio via c15c7cc June 23, 2026 09:41
@llogiq

llogiq commented Jun 23, 2026

Copy link
Copy Markdown
Author

I had missed one place in the tests when adding files to the commit. Sorry.

@llogiq llogiq force-pushed the not-even-once-cell branch from c15c7cc to 9d9e473 Compare June 23, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants