HBASE-29809 Unify region reopening methods to use throttled implement…#7818
Open
liuxiaocs7 wants to merge 4 commits into
Open
HBASE-29809 Unify region reopening methods to use throttled implement…#7818liuxiaocs7 wants to merge 4 commits into
liuxiaocs7 wants to merge 4 commits into
Conversation
Member
Author
|
Hi, @ajkh88 and @charlesconnell, could you help take a look when free, thanks! |
charlesconnell
approved these changes
Mar 17, 2026
Apache9
reviewed
Apr 6, 2026
There was a problem hiding this comment.
Pull request overview
Updates region-reopen call sites to consistently use the throttled reopening implementation (HBASE-29809), so region reopening honors configured throttling.
Changes:
- Switch
RegionsRecoveryChoreto callHMaster.reopenRegionsThrottledinstead of the unthrottled reopen method. - Update
TestRegionsRecoveryChoreexpectations to verify throttled reopen calls. - Deprecate
HMaster.reopenRegions(...)in favor ofreopenRegionsThrottled(...)and fix minor logging constant/message typos in the chore.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionsRecoveryChore.java | Updates Mockito verifications to assert throttled region reopen calls. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java | Adds HMaster import to support Javadoc references to throttled reopen entrypoint. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionsRecoveryChore.java | Uses throttled reopen method and fixes typo in error constant/log message. |
| hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java | Marks the unthrottled reopen helper as deprecated and points callers to throttled variant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Apache9
reviewed
Jun 15, 2026
| import org.apache.hadoop.hbase.UnknownRegionException; | ||
| import org.apache.hadoop.hbase.client.TableDescriptor; | ||
| import org.apache.hadoop.hbase.conf.ConfigKey; | ||
| import org.apache.hadoop.hbase.master.HMaster; |
Member
Author
There was a problem hiding this comment.
Strange, Let me check!
Thanks
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

…ation