Test AbstractDatastoreInitializer and its production subclasses; fix bugs found along the way

[borinquenkid]

Summary

• Adds unit coverage for AbstractDatastoreInitializer via a new shared TestDatastoreInitializer test double.
• Closes test coverage gaps in the three production subclasses (Hibernate5, Hibernate7, MongoDB). grails-data-neo4j was excluded: it's not part of the root build, its README says it hasn't been updated for the current release, and its own standalone build is broken.
• Fixes four real bugs found while writing that coverage, all following the same pattern - a customizable field silently ignored because a bean-registration/config-lookup site hardcoded a literal instead:
  • MongoDbDataStoreSpringInitializer.mongoBeanName ignored when building a new MongoClient from scratch.
  • MongoDbDataStoreSpringInitializer.databaseName ignored entirely - actively broken for real Grails+MongoDB apps via MongodbGrailsPlugin, which sets it expecting a default database name.
  • HibernateDatastoreSpringInitializer.defaultDataSourceBeanName hardcoded around instead of used, in both Hibernate5 and Hibernate7.
  • HibernateDatastoreSpringInitializer.enableReload ignored entirely - HibernateGrailsPlugin sets it to enable dev-mode reload by default, but it never reached HibernateConnectionSourceSettings.
• Removes dead code identified via git archaeology (properties set by real plugin code but never read anywhere, with no surviving mechanism to restore): registerApplicationIfNotPresent (base class, dead since a 2018 simplification commit) and grailsPlugin (Hibernate initializers, dead since a January 2017 refactor). Also removes getTestDbUrl(), defaultSessionFactoryBeanName, and SESSION_FACTORY_BEAN_NAME from both Hibernate initializers - confirmed unused anywhere in the reachable codebase.

Test plan

• grails-datamapping-core full test suite + codeStyle (Checkstyle/CodeNarc)
• grails-data-hibernate7 full test suite + codeStyle
• grails-data-hibernate5 full test suite + codeStyle
• grails-data-mongodb-core full test suite (real MongoDB via Testcontainers) + codeStyle
• grails-data-mongodb (grails-plugin) compiles clean
• Every bug fix has a dedicated regression test, including two verified end-to-end against a live H2-backed HibernateDatastore/live MongoDB container, not just unit-level

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com

[Copilot]

Pull request overview

This PR strengthens GORM datastore bootstrap reliability by adding focused test coverage for AbstractDatastoreInitializer (via a shared concrete test double) and by adding/expanding regression tests for the Hibernate 5/7 and MongoDB Spring initializers. Along the way, it fixes several initializer customization bugs where configurable fields were previously ignored, and removes now-dead initializer/plugin wiring.

Changes:

• Add unit coverage for AbstractDatastoreInitializer using a reusable TestDatastoreInitializer test double.
• Fix ignored customization points in MongoDB and Hibernate initializers (database name fallback, Mongo client bean name, default datasource bean name, enableReload fallback).
• Remove dead initializer/plugin configuration flags and related unused constants/methods; expand regression tests across Hibernate 5/7 and MongoDB.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
grails-datamapping-core/src/test/groovy/org/grails/datastore/gorm/bootstrap/TestDatastoreInitializer.groovy	New concrete test double for exercising AbstractDatastoreInitializer behavior in isolation.
grails-datamapping-core/src/test/groovy/org/grails/datastore/gorm/bootstrap/AbstractDatastoreInitializerWebApplicationSpec.groovy	Switch to shared test double; keeps OSIV web-detection coverage in datamapping-core without spring-web.
grails-datamapping-core/src/test/groovy/org/grails/datastore/gorm/bootstrap/AbstractDatastoreInitializerSpec.groovy	New unit spec covering constructors, service loading, bean registration helpers, and baseline behaviors.
grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/bootstrap/AbstractDatastoreInitializer.groovy	Small API/behavior refinements (static helpers, safer comparisons, reflective instantiation updates, dead flag removal).
grails-data-neo4j/grails-plugin/src/main/groovy/org/grails/datastore/gorm/neo4j/Neo4jGrailsPlugin.groovy	Remove writes to deleted initializer flag.
grails-data-mongodb/grails-plugin/src/main/groovy/grails/plugins/mongodb/MongodbGrailsPlugin.groovy	Remove writes to deleted initializer flag.
grails-data-mongodb/core/src/test/groovy/grails/mongodb/bootstrap/MongoDbDataStoreSpringInitializerUnitSpec.groovy	New unit coverage for Mongo initializer mapping discrimination and deprecated setters, plus database-name fallback behavior.
grails-data-mongodb/core/src/test/groovy/grails/mongodb/bootstrap/MongoDbDataStoreSpringInitializerSpec.groovy	New integration/regression tests for database-name fallback, custom Mongo bean name, pre-existing client reuse, and package scanning.
grails-data-mongodb/core/src/main/groovy/grails/mongodb/bootstrap/MongoDbDataStoreSpringInitializer.groovy	Honor mongoBeanName when creating a client; implement database-name fallback injection.
grails-data-hibernate7/grails-plugin/src/test/groovy/grails/orm/bootstrap/HibernateDatastoreSpringInitializerSpec.groovy	Add regression tests for default datasource bean naming, enableReload fallback, constructors, OSIV registration, and registry error cases.
grails-data-hibernate7/grails-plugin/src/main/groovy/grails/plugin/hibernate/HibernateGrailsPlugin.groovy	Remove dead initializer flags (registerApplicationIfNotPresent, grailsPlugin) writes.
grails-data-hibernate7/grails-plugin/src/main/groovy/grails/orm/bootstrap/HibernateDatastoreSpringInitializer.groovy	Fix default datasource bean-name usage; add enableReload fallback injection; remove unused constants/method.
grails-data-hibernate5/grails-plugin/src/test/groovy/grails/orm/bootstrap/HibernateDatastoreSpringInitializerSpec.groovy	Add regression tests parallel to Hibernate7 for naming/fallback/constructors/OSIV/DataSource reuse.
grails-data-hibernate5/grails-plugin/src/main/groovy/grails/plugin/hibernate/HibernateGrailsPlugin.groovy	Remove dead initializer flags (registerApplicationIfNotPresent, grailsPlugin) writes.
grails-data-hibernate5/grails-plugin/src/main/groovy/grails/orm/bootstrap/HibernateDatastoreSpringInitializer.groovy	Fix default datasource bean-name usage; add enableReload fallback injection; tighten interceptor class typing; remove unused constants/method.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[bito-code-review]

The user's concern regarding test flakiness due to external environment variables or system properties is valid. To make the test deterministic, you should ensure the PropertyResolver or Environment used in the test is isolated from the system environment.

Instead of relying on a default StandardEnvironment, you can use a MutablePropertySources instance with only the necessary properties, or a MapPropertySource that does not delegate to system properties. For example, when initializing the HibernateDatastoreSpringInitializer in your test, pass a PropertySourcesPropertyResolver configured with an empty or minimal MutablePropertySources instead of the default environment.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.9084%. Comparing base (506228b) to head (5e6cc3b).

Additional details and impacted files

@@                         Coverage Diff                          @@
##             feat/enable-datamapping-rx     #16147        +/-   ##
====================================================================
+ Coverage                       52.8254%   52.9084%   +0.0830%     
- Complexity                        18871      18910        +39     
====================================================================
  Files                              2079       2079                
  Lines                             97207      97217        +10     
  Branches                          16873      16875         +2     
====================================================================
+ Hits                              51350      51436        +86     
+ Misses                            38446      38374        -72     
+ Partials                           7411       7407         -4     

Files with missing lines	Coverage Δ
...bootstrap/MongoDbDataStoreSpringInitializer.groovy	83.0769% <100.0000%> (+31.2912%)	⬆️
.../grails/plugins/mongodb/MongodbGrailsPlugin.groovy	0.0000% <ø> (ø)
...gorm/bootstrap/AbstractDatastoreInitializer.groovy	82.9268% <100.0000%> (+38.4824%)	⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[testlens-app]

✅ All tests passed ✅

🏷️ Commit: 5e6cc3b
▶️ Tests: 44509 executed
⚪️ Checks: 56/56 completed

---

Learn more about TestLens at testlens.app.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

Suppressed comments (1)

grails-data-mongodb/core/src/main/groovy/grails/mongodb/bootstrap/MongoDbDataStoreSpringInitializer.groovy:97

• applyDatabaseNameFallback() will inject the value of databaseName into the configuration whenever it differs from the default. Since setDatabaseName(String) accepts null/blank values, this method can end up writing a null/empty grails.mongodb.databaseName into the PropertyResolver, which can break downstream Mongo settings resolution. Guard against null/blank and treat it as “not customized” (or reset to DEFAULT_DATABASE_NAME).

    protected void applyDatabaseNameFallback() {
        if (databaseName == DEFAULT_DATABASE_NAME || configuration.containsProperty(MongoSettings.SETTING_DATABASE_NAME)) {
            return
        }