Conversation
Signed-off-by: tison <wander4096@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the HLL HIP estimator to reuse the existing shared INVERSE_POWERS_OF_2 lookup table (previously used by CPC), removing the local inv_pow2 helper and enabling the shared table module when the hll feature is selected.
Changes:
- Switched HIP KxQ updates to use
INVERSE_POWERS_OF_2[...]table lookups instead ofinv_pow2(...). - Removed the now-redundant local
inv_pow2function fromhll/estimator.rs. - Expanded
common::inv_pow2_tablemodule gating to compile under eithercpcorhllfeatures.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| datasketches/src/hll/estimator.rs | Uses the shared inverse-powers table for HIP KxQ accumulation and removes the local inverse-power helper. |
| datasketches/src/common/mod.rs | Makes inv_pow2_table available when building with the hll feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PsiACE
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.