Inline Word::to_ident - #2427
Draft
fyrsta7 wants to merge 1 commit into
Draft
Conversation
LucaCappelletti94
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This marks
Word::to_identas inline.Word::to_identis a small helper used while building identifier-heavy AST nodes. It clones the word value, copies the quote style and attaches the caller-provided span. Letting the compiler inline it removes the call boundary from parser hot paths without changing behavior.Validation
cargo fmt --all --checkgit diff --checkcargo testcargo bench --manifest-path sqlparser_bench/Cargo.toml --bench sqlparser_bench -- --baseline upstream-mainBenchmark
I ran the repository benchmark suite on the same machine, first saving an
upstream-mainbaseline from the currentmainbranch and then comparing this branch against it.word_to_ident/to_ident_100xparse_identifiers/select_100_columnsparse_identifiers/select_100_qualified_columnsparse_compound_keyword_chain/chain_5parse_prefix_keyword_call_chain/chain_10The broader parsing benchmarks were also neutral to positive in this run, with the largest median regression at 1.51%.