Skip to content

docs: triage bug vs enhancement and apply type labels consistently#4768

Open
andygrove wants to merge 1 commit into
apache:mainfrom
andygrove:triage-bug-label
Open

docs: triage bug vs enhancement and apply type labels consistently#4768
andygrove wants to merge 1 commit into
apache:mainfrom
andygrove:triage-bug-label

Conversation

@andygrove

Copy link
Copy Markdown
Member

Which issue does this PR close?

N/A. This is a small documentation and tooling change to the triage process.

Rationale for this change

The requires-triage label is auto-applied to every new issue, not just bug reports. The bug triage guide and the bug-triage skill, however, only described assigning priority and area labels, implicitly treating every triaged issue as a bug. As a result the bug label was applied inconsistently and was sometimes present on issues that are really feature requests. This makes the first triage decision explicit: classify each issue as a bug or an enhancement, and apply the matching type label.

What changes are included in this PR?

  • docs/source/contributor-guide/bug_triage.md: add a "Type Labels" section describing the bug and enhancement labels and the rule that an issue must never carry both, that the type is decided from issue content rather than title wording, and that only bugs receive a priority label. The "For New Issues" steps now start with the bug-vs-enhancement decision.
  • .claude/skills/bug-triage/SKILL.md: the triage pass now classifies each issue as a bug or an enhancement first, applies bug (plus a priority) or enhancement (no priority), always removes the opposite type label so the two are mutually exclusive, and reports bugs and enhancements separately in the summary issue.

How are these changes tested?

Documentation and skill-instruction changes only; there is no code to test. The gh label commands in the skill use labels that already exist in the repository (bug, enhancement, the priority:* and area:* labels).

Update the bug triage guide and bug-triage skill so triage classifies each
requires-triage issue as a bug or an enhancement and applies the matching type
label. requires-triage is auto-applied to all new issues, not just bug reports,
so the first decision is always bug vs enhancement. Bugs get the bug label plus
a priority label; enhancements get the enhancement label and no priority. An
issue must never carry both bug and enhancement.
- `bug`: something is broken. Wrong results, crashes, panics, regressions,
test/CI failures, or any behavior that differs from what Comet should do.
- `enhancement`: a request for new functionality or improvement that is not
yet expected to work. New expression/operator support, a new config, a

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need to define a rule to break a tie, if bot cannot decide ultimately if the issue is a bug or feature?

@comphead comphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants