feat: add unsupported metadata column names to fallback reasons#4758
Open
hsiang-c wants to merge 5 commits into
Open
feat: add unsupported metadata column names to fallback reasons#4758hsiang-c wants to merge 5 commits into
hsiang-c wants to merge 5 commits into
Conversation
comphead
reviewed
Jun 29, 2026
Comment on lines
+92
to
+96
| plan.expressions.flatMap { | ||
| case a: Attribute => | ||
| a.isMetadataCol | ||
| case _ => false | ||
| }) | ||
| if (a.isMetadataCol) Option(a.name) else Option.empty | ||
| case _ => Option.empty | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| plan.expressions.flatMap { | |
| case a: Attribute => | |
| a.isMetadataCol | |
| case _ => false | |
| }) | |
| if (a.isMetadataCol) Option(a.name) else Option.empty | |
| case _ => Option.empty | |
| } | |
| plan.expressions.collect { | |
| case a: Attribute if a.isMetadataCol => a.name | |
| } |
Contributor
Author
There was a problem hiding this comment.
Thanks for your suggestion, this is better.
comphead
reviewed
Jun 29, 2026
comphead
reviewed
Jun 29, 2026
comphead
reviewed
Jun 29, 2026
| a.isMetadataCol | ||
| case _ => false | ||
| }) | ||
| def hasMetadataCol(plan: SparkPlan): Seq[String] = { |
Contributor
There was a problem hiding this comment.
Please rename the method, has prefix usually implies the Bool output
hsiang-c
changed the title
andygrove
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #. #4757
Rationale for this change
[COMET: Metadata column is not supported]and users might want to know the column names that trigger the fallback.What changes are included in this PR?
How are these changes tested?
CometSort +- CometSinkPlaceHolder +- CometColumnarExchange +- Project +- Filter +- BatchScan spark_catalog.default.table [COMET: Metadata column _spec_id, _partition, _file, _pos is not supported]