feat(parquet): implement file commit protocol for native Parquet writes#4746
Draft
peterxcli wants to merge 1 commit into
Draft
feat(parquet): implement file commit protocol for native Parquet writes#4746peterxcli wants to merge 1 commit into
peterxcli wants to merge 1 commit into
Conversation
Native Parquet writes now write to the task temp file returned by Spark's FileCommitProtocol, then commit or abort tasks through Spark's standard lifecycle. Pass the task output path through the native Parquet writer proto, wire commit protocol setup in CometNativeWriteExec, and assert committed output naming/cleanup in CometParquetWriterSuite.
Contributor
|
Thanks @peterxcli please check on your fork https://github.com/apache/datafusion-comet/actions/workflows/spark_sql_writer_tests.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Parquet writes now write to the task temp file returned by Spark's FileCommitProtocol, then commit or abort tasks through Spark's standard lifecycle.
Pass the task output path through the native Parquet writer proto, wire commit protocol setup in CometNativeWriteExec, and assert committed output naming/cleanup in CometParquetWriterSuite.
Which issue does this PR close?
Closes #2827.
Rationale for this change
What changes are included in this PR?
How are these changes tested?