RAT-541: create testhelpers.data package - #655
Draft
Claudenw wants to merge 38 commits into
Draft
Conversation
ottlinger
changed the title
Claudenw
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Claudenw
force-pushed
the
RAT-541_create-testhelper_data-package
branch
3 times, most recently
from
June 25, 2026 10:06
fddbe0b to
c484029
Compare
Add testing Expanded testing to include multiple file system types Fix recursion issue in DocumentName equals and compareTo Additional migration to assertj Changed File options to return DocumentName instances. Cleaned up Sonar review issues
Change to ReportConfiguration.IODescriptor usage
Reworked tests for more complete coverage. Fixed issue with ReportTestDataProvider.java
Add testing Expanded testing to include multiple file system types Fix recursion issue in DocumentName equals and compareTo Additional migration to assertj Changed File options to return DocumentName instances. Cleaned up Sonar review issues
Claudenw
force-pushed
the
RAT-541_create-testhelper_data-package
branch
from
July 23, 2026 21:20
7ba796d to
fd06cde
Compare
Claudenw
marked this pull request as ready for review
July 26, 2026 10:34
|
Claudenw
marked this pull request as draft
July 27, 2026 10:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The
testselpers.datapackage is intended to provide test definition and validation in a UI agnostic manner.Specifically tests for UIs will be provided with the internal command line structure. They will convert that into the UI based configuration definition and execute the report. The result of the report will the be validated by the test definition.
In order to do this across multiple UI implementations the Reporter.Output class was developed. This contains the ReportConfiguration, the XML document generated during the run, and the ClaimStatistics (results).
TestData
The
TestDataclass is the test definition and contains the instructions to setup a directory structure for the test, a list pairs ofcommons.cli.optionand an array of string that is the list of arguments for the option, and a validator to validate the results.ValidatorData
The
ValidatorDatacontains the Reporter.Output and the base directory into which the test data was written and from which the report was run.Testing changes
The test changes in this PR are minimal and mostly revolve around the change in
Reporter.execute()to returning the Reporter.Output objectSpecific Changes:
Additional changes
Additional changes made to resolve some spotbugs errors.