Skip to content

CLVM enhancements and fixes#12617

Draft
Pearl1594 wants to merge 92 commits into
mainfrom
clvm-enhancements
Draft

CLVM enhancements and fixes#12617
Pearl1594 wants to merge 92 commits into
mainfrom
clvm-enhancements

allow storage browser to list lv in clvm, fix clvm shrink, overprovis…

419bf31
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 12, 2026 in 5m 13s

Quality Gate failed

Failed conditions
1 Security Hotspot
32.4% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 504 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 119 to 64, Complexity from 23 to 14, Nesting Level from 3 to 2, Number of Variables from 42 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSGr-GQEym9Vaojp&open=AZ6opSGr-GQEym9Vaojp&pullRequest=12617

Check warning on line 900 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this hard-coded path-delimiter. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSWO-GQEym9Vaoki&open=AZ6opSWO-GQEym9Vaoki&pullRequest=12617

Check warning on line 82 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the missing @Deprecated annotation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSjr-GQEym9VaomU&open=AZ6opSjr-GQEym9VaomU&pullRequest=12617

Check warning on line 109 in plugins/storage/volume/default/src/test/java/org/apache/cloudstack/storage/datastore/driver/CloudStackPrimaryDataStoreDriverImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSer-GQEym9VaomB&open=AZ6opSer-GQEym9VaomB&pullRequest=12617

Check warning on line 470 in engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSL3-GQEym9Vaojt&open=AZ6opSL3-GQEym9Vaojt&pullRequest=12617

Check failure on line 665 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSek-GQEym9Vaols&open=AZ6opSek-GQEym9Vaols&pullRequest=12617

Check warning on line 655 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSsy-GQEym9Vaomo&open=AZ6opSsy-GQEym9Vaomo&pullRequest=12617

Check warning on line 54 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSjr-GQEym9VaomS&open=AZ6opSjr-GQEym9VaomS&pullRequest=12617

Check warning on line 377 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSlQ-GQEym9Vaomf&open=AZ6opSlQ-GQEym9Vaomf&pullRequest=12617

Check warning on line 234 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtPostMigrationCommandWrapperTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'org.libvirt.LibvirtException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSZ6-GQEym9VaolJ&open=AZ6opSZ6-GQEym9VaolJ&pullRequest=12617

Check failure on line 2730 in server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSlQ-GQEym9Vaomg&open=AZ6opSlQ-GQEym9Vaomg&pullRequest=12617

Check failure on line 285 in server/src/main/java/com/cloud/storage/clvm/ClvmPoolManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Null is returned but a "Boolean" is expected. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSjr-GQEym9Vaoma&open=AZ6opSjr-GQEym9Vaoma&pullRequest=12617

Check failure on line 708 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSek-GQEym9Vaolt&open=AZ6opSek-GQEym9Vaolt&pullRequest=12617

Check warning on line 227 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this method so that its implementation is not identical to "testCLVMPoolLocalPathFormat" on line 216. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSea-GQEym9Vaolh&open=AZ6opSea-GQEym9Vaolh&pullRequest=12617

Check warning on line 5763 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ68tNXocB6sisSafVyE&open=AZ68tNXocB6sisSafVyE&pullRequest=12617

Check failure on line 471 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "--unbuffered" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSWO-GQEym9VaokM&open=AZ6opSWO-GQEym9VaokM&pullRequest=12617

Check warning on line 470 in plugins/storage/volume/default/src/main/java/org/apache/cloudstack/storage/datastore/driver/CloudStackPrimaryDataStoreDriverImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 80 to 64, Complexity from 15 to 14, Nesting Level from 4 to 2, Number of Variables from 19 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSfI-GQEym9VaomG&open=AZ6opSfI-GQEym9VaomG&pullRequest=12617

Check warning on line 829 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this hard-coded path-delimiter. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSWO-GQEym9Vaokh&open=AZ6opSWO-GQEym9Vaokh&pullRequest=12617

Check failure on line 2459 in engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 63 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6vhM4-K2aTjAWcvesP&open=AZ6vhM4-K2aTjAWcvesP&pullRequest=12617

Check warning on line 550 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Script"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSWO-GQEym9Vaokb&open=AZ6opSWO-GQEym9Vaokb&pullRequest=12617

Check failure on line 5799 in plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "/dev/" 3 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ68tNXocB6sisSafVyC&open=AZ68tNXocB6sisSafVyC&pullRequest=12617

Check failure on line 1028 in plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/storage/ClvmStorageAdaptorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSek-GQEym9Vaol8&open=AZ6opSek-GQEym9Vaol8&pullRequest=12617

Check warning on line 113 in engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSA5-GQEym9VaojU&open=AZ6opSA5-GQEym9VaojU&pullRequest=12617

Check warning on line 84 in engine/storage/src/main/java/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_storagePoolDao" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opR7h-GQEym9VaojG&open=AZ6opR7h-GQEym9VaojG&pullRequest=12617

Check warning on line 278 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ6opSGr-GQEym9Vaojm&open=AZ6opSGr-GQEym9Vaojm&pullRequest=12617
View more details on SonarQubeCloud