Skip to content

fix(examples): bound image telephone downloads #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ghraven wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(examples): bound image telephone downloads #879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion examples/image-telephone/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@
from burr.core.action import action
from burr.lifecycle import PostRunStepHook

IMAGE_DOWNLOAD_TIMEOUT_SECONDS = 30

# import hamilton modules that define the DAGs for image captioning and image generation
caption_images = dataflows.import_module("caption_images", "elijahbenizzy")
generate_images = dataflows.import_module("generate_images", "elijahbenizzy")
Expand All @@ -67,7 +69,11 @@ def post_run_step(self, *, state: "State", action: "Action", **future_kwargs):
image_url = state["current_image_location"]
image_name = "image_" + str(state["__SEQUENCE_ID"]) + ".png"
with open(os.path.join(self.path, image_name), "wb") as f:
f.write(requests.get(image_url).content)
response = requests.get(
image_url, timeout=IMAGE_DOWNLOAD_TIMEOUT_SECONDS
)
response.raise_for_status()
f.write(response.content)
print(f"Saved image to {self.path}/{image_name}")


Expand Down
8 changes: 7 additions & 1 deletion examples/integrations/hamilton/image-telephone/application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
from burr.integrations import hamilton
from burr.lifecycle import PostRunStepHook

IMAGE_DOWNLOAD_TIMEOUT_SECONDS = 30

caption_images = dataflows.import_module("caption_images", "elijahbenizzy")
generate_images = dataflows.import_module("generate_images", "elijahbenizzy")

Expand All @@ -53,7 +55,11 @@ def post_run_step(self, *, state: "State", action: "Action", **future_kwargs):
image_url = state["current_image_location"]
image_name = "image_" + str(state["__SEQUENCE_ID"]) + ".png"
with open(os.path.join(self.path, image_name), "wb") as f:
f.write(requests.get(image_url).content)
response = requests.get(
image_url, timeout=IMAGE_DOWNLOAD_TIMEOUT_SECONDS
)
response.raise_for_status()
f.write(response.content)
print(f"Saved image to {self.path}/{image_name}")


Expand Down
Loading