GH-50913: [C++][Dataset] Replace RapidJSON with JsonWriter - #50914
Conversation
69ed795 to
9f9907c
Compare
|
Can we fix the Meson job failure as a separated task to test Meson related changes in this PR before we proceed this PR? https://github.com/apache/arrow/actions/runs/32293675583/job/96201011745?pr=50914#step:6:1103 |
9f9907c to
1835213
Compare
HuaHuaY
left a comment
There was a problem hiding this comment.
Sorry, I wasn't following the rapidjson replacement work before today. But as far as this PR goes, it looks good to me.
| test_name, | ||
| sources: value['sources'], | ||
| dependencies: [arrow_dataset_test_dep, val.get('dependencies', [])], | ||
| dependencies: [arrow_dataset_test_dep, value.get('dependencies', [])], |
There was a problem hiding this comment.
Just provide information to other reviewers: It is a historical issue, but it wasn't exposed because rapidjson only requires header files and doesn't need to link libraries.
|
@HuaHuaY Thanks for the review! |
|
@HuaHuaY Do you want to merge this? |
Yes. Let me merge this. |
You need to use the merge script by the way. |
|
Thanks to @Reranko05 for the fix and to @pitrou for the help with merging the code. |
Rationale for this change
This PR continues the RapidJSON → simdjson migration by replacing the remaining RapidJSON usage in the Dataset JSON test with Arrow's existing
JsonWriter.Changes
rapidjson::Writerandrapidjson::OStreamWrapperwitharrow::json::JsonWriter.SizeTypeusage with theJsonWriterinterface.Fixes: #50913