Add option to build and serve posts with dates in the future - #774
Add option to build and serve posts with dates in the future#774ianmcook wants to merge 2 commits into
Conversation
|
Preview URL: https://ianmcook.github.io/arrow-site If the preview URL doesn't work, you may forget to configure your fork repository for preview. |
ianmcook
changed the title
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
Is there any reason not to do this for a local server? Feels like it'd be easier to just always enable it
|
Hmm, good question. Someone might have a reason, I suppose, but I can't think of an obvious one. |
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
Let's enable --future by default.
Done in a08e969 |
| future = ENV["JEKYLL_FUTURE"] | ||
| command_line << "--future" if future |
There was a problem hiding this comment.
We can simplify this:
| future = ENV["JEKYLL_FUTURE"] | |
| command_line << "--future" if future | |
| command_line << "--future" if ENV["JEKYLL_FUTURE"] |
BTW, do we need this? If we need this, how about enable this only for preview?
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
index 9b963f13831..86236479f95 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -64,6 +64,9 @@ jobs:
export JEKYLL_DESTINATION=../build
export JEKYLL_ENV=production
export JEKYLL_EXTRA_CONFIG=_extra_config.yml
+ if [ "${GITHUB_REPOSITORY}" != "apache/arrow-site" ]; then
+ export JEKYLL_FUTURE=1
+ fi
bundle exec rake generate
- name: Checkout asf-site
uses: actions/checkout@v6
| bundle exec rake | ||
| ``` | ||
|
|
||
| To include posts with future dates: |
There was a problem hiding this comment.
are we changing to always allow future dates? If so we can probably remove this part too
4 participants
No description provided.